From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Jonathan McDowell <noodles@earth.li>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: [PATCH net-next 2/2] net: pcs: lynx: don't print an_enabled in pcs_get_state()
Date: Wed, 15 Mar 2023 14:46:49 +0000 [thread overview]
Message-ID: <E1pcSOv-00DiAu-2D@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ZBHaQDM+G/o/UW3i@shell.armlinux.org.uk>
an_enabled will be going away, and in any case, pcs_get_state() should
not be updating this member. Remove the print.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/pcs/pcs-lynx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/pcs/pcs-lynx.c b/drivers/net/pcs/pcs-lynx.c
index 3903f3baba2b..622c3de3f3a8 100644
--- a/drivers/net/pcs/pcs-lynx.c
+++ b/drivers/net/pcs/pcs-lynx.c
@@ -112,11 +112,11 @@ static void lynx_pcs_get_state(struct phylink_pcs *pcs,
}
dev_dbg(&lynx->mdio->dev,
- "mode=%s/%s/%s link=%u an_enabled=%u an_complete=%u\n",
+ "mode=%s/%s/%s link=%u an_complete=%u\n",
phy_modes(state->interface),
phy_speed_to_str(state->speed),
phy_duplex_to_str(state->duplex),
- state->link, state->an_enabled, state->an_complete);
+ state->link, state->an_complete);
}
static int lynx_pcs_config_giga(struct mdio_device *pcs, unsigned int mode,
--
2.30.2
next prev parent reply other threads:[~2023-03-15 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 14:46 [PATCH net-next 0/2] Minor fixes for pcs_get_state() implementations Russell King (Oracle)
2023-03-15 14:46 ` [PATCH net-next 1/2] net: pcs: xpcs: remove double-read of link state when using AN Russell King (Oracle)
2023-03-16 9:44 ` Steen Hegelund
2023-03-16 16:12 ` Russell King (Oracle)
2023-03-17 8:59 ` Steen Hegelund
2023-03-15 14:46 ` Russell King (Oracle) [this message]
2023-03-16 9:45 ` [PATCH net-next 2/2] net: pcs: lynx: don't print an_enabled in pcs_get_state() Steen Hegelund
2023-03-17 8:30 ` [PATCH net-next 0/2] Minor fixes for pcs_get_state() implementations patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1pcSOv-00DiAu-2D@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noodles@earth.li \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).