From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: chenhao418@huawei.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jijie Shao <shaojijie@huawei.com>,
lanhao@huawei.com, liuyonglong@huawei.com,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
shenjian15@huawei.com, wangjie125@huawei.com,
wangpeiyang1@huawei.com
Subject: [PATCH net-next 3/7] net: phy: move call to start aneg
Date: Thu, 14 Sep 2023 16:35:41 +0100 [thread overview]
Message-ID: <E1qgoNZ-007a4I-W1@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ZQMn+Wkvod10vdLd@shell.armlinux.org.uk>
Move the call to start auto-negotiation inside the lock in the PHYLIB
state machine, calling the locked variant _phy_start_aneg(). This
avoids unnecessarily releasing and re-acquiring the lock.
Tested-by: Jijie Shao <shaojijie@huawei.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/phy/phy.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 990d387b31bd..5bb33af2a4cb 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -1489,14 +1489,15 @@ void phy_state_machine(struct work_struct *work)
break;
}
+ if (needs_aneg) {
+ err = _phy_start_aneg(phydev);
+ func = &_phy_start_aneg;
+ }
+
mutex_unlock(&phydev->lock);
- if (needs_aneg) {
- err = phy_start_aneg(phydev);
- func = &phy_start_aneg;
- } else if (do_suspend) {
+ if (do_suspend)
phy_suspend(phydev);
- }
if (err == -ENODEV)
return;
--
2.30.2
next prev parent reply other threads:[~2023-09-14 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 15:34 [PATCH net-next 0/7] net: phy: avoid race when erroring stopping PHY Russell King (Oracle)
2023-09-14 15:35 ` [PATCH net-next 1/7] net: phy: always call phy_process_state_change() under lock Russell King (Oracle)
2023-09-14 18:21 ` Florian Fainelli
2023-09-18 12:33 ` Marek Szyprowski
2023-09-18 12:55 ` Andrew Lunn
2023-09-18 13:05 ` Marek Szyprowski
2023-09-18 13:07 ` Russell King (Oracle)
2023-09-18 13:06 ` Russell King (Oracle)
2023-09-18 13:15 ` Marek Szyprowski
2023-09-14 15:35 ` [PATCH net-next 2/7] net: phy: call phy_error_precise() while holding the lock Russell King (Oracle)
2023-09-14 18:21 ` Florian Fainelli
2023-09-14 15:35 ` Russell King (Oracle) [this message]
2023-09-14 18:22 ` [PATCH net-next 3/7] net: phy: move call to start aneg Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 4/7] net: phy: move phy_suspend() to end of phy_state_machine() Russell King (Oracle)
2023-09-14 18:22 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 5/7] net: phy: move phy_state_machine() Russell King (Oracle)
2023-09-14 18:22 ` Florian Fainelli
2023-09-14 15:35 ` [PATCH net-next 6/7] net: phy: split locked and unlocked section of phy_state_machine() Russell King (Oracle)
2023-09-14 18:39 ` Florian Fainelli
2023-09-14 15:36 ` [PATCH net-next 7/7] net: phy: convert phy_stop() to use split state machine Russell King (Oracle)
2023-09-14 18:39 ` Florian Fainelli
2023-09-17 13:40 ` [PATCH net-next 0/7] net: phy: avoid race when erroring stopping PHY patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1qgoNZ-007a4I-W1@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=lanhao@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).