* [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode
@ 2024-03-06 10:51 Russell King (Oracle)
2024-03-06 18:50 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2024-03-06 10:51 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit
Cc: Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev
Update the Marvell 88e6185 PCS driver to use neg_mode rather than the
mode argument to match the other updated PCS drivers.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mv88e6xxx/pcs-6185.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/pcs-6185.c b/drivers/net/dsa/mv88e6xxx/pcs-6185.c
index 4d677f836807..5a27d047a38e 100644
--- a/drivers/net/dsa/mv88e6xxx/pcs-6185.c
+++ b/drivers/net/dsa/mv88e6xxx/pcs-6185.c
@@ -95,7 +95,7 @@ static void mv88e6185_pcs_get_state(struct phylink_pcs *pcs,
}
}
-static int mv88e6185_pcs_config(struct phylink_pcs *pcs, unsigned int mode,
+static int mv88e6185_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode,
phy_interface_t interface,
const unsigned long *advertising,
bool permit_pause_to_mac)
@@ -137,6 +137,7 @@ static int mv88e6185_pcs_init(struct mv88e6xxx_chip *chip, int port)
mpcs->chip = chip;
mpcs->port = port;
mpcs->phylink_pcs.ops = &mv88e6185_phylink_pcs_ops;
+ mpcs->phylink_pcs.neg_mode = true;
irq = mv88e6xxx_serdes_irq_mapping(chip, port);
if (irq) {
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode
2024-03-06 10:51 [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode Russell King (Oracle)
@ 2024-03-06 18:50 ` Andrew Lunn
2024-03-06 23:18 ` Florian Fainelli
2024-03-08 5:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2024-03-06 18:50 UTC (permalink / raw)
To: Russell King (Oracle)
Cc: Heiner Kallweit, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On Wed, Mar 06, 2024 at 10:51:46AM +0000, Russell King (Oracle) wrote:
> Update the Marvell 88e6185 PCS driver to use neg_mode rather than the
> mode argument to match the other updated PCS drivers.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode
2024-03-06 10:51 [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode Russell King (Oracle)
2024-03-06 18:50 ` Andrew Lunn
@ 2024-03-06 23:18 ` Florian Fainelli
2024-03-08 5:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2024-03-06 23:18 UTC (permalink / raw)
To: Russell King (Oracle), Andrew Lunn, Heiner Kallweit
Cc: Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev
On 3/6/24 02:51, Russell King (Oracle) wrote:
> Update the Marvell 88e6185 PCS driver to use neg_mode rather than the
> mode argument to match the other updated PCS drivers.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode
2024-03-06 10:51 [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode Russell King (Oracle)
2024-03-06 18:50 ` Andrew Lunn
2024-03-06 23:18 ` Florian Fainelli
@ 2024-03-08 5:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-08 5:00 UTC (permalink / raw)
To: Russell King
Cc: andrew, hkallweit1, f.fainelli, olteanv, davem, edumazet, kuba,
pabeni, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 06 Mar 2024 10:51:46 +0000 you wrote:
> Update the Marvell 88e6185 PCS driver to use neg_mode rather than the
> mode argument to match the other updated PCS drivers.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/mv88e6xxx/pcs-6185.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode
https://git.kernel.org/netdev/net-next/c/84c49aac0ea4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-08 5:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-06 10:51 [PATCH net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode Russell King (Oracle)
2024-03-06 18:50 ` Andrew Lunn
2024-03-06 23:18 ` Florian Fainelli
2024-03-08 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).