* [PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops
@ 2024-04-18 10:51 Russell King (Oracle)
2024-04-19 11:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Russell King (Oracle) @ 2024-04-18 10:51 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit
Cc: George McCollister, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
The kernel build bot identified the following mistake in the recently
merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC
operations") patch:
drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
| ^~~~~~~~~~~~~~~~~~~~~~~
Fix the omitted assignment of ds->phylink_mac_ops.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
Normal builds don't catch this, and W=1 produces 5.3klines of warnings,
so its pretty difficult to build-test changes such as these and have
confidence that they are correct. If anyone knows of a solution to
this problem...
drivers/net/dsa/xrs700x/xrs700x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/xrs700x/xrs700x.c b/drivers/net/dsa/xrs700x/xrs700x.c
index 6605fa44bcf0..de3b768f2ff9 100644
--- a/drivers/net/dsa/xrs700x/xrs700x.c
+++ b/drivers/net/dsa/xrs700x/xrs700x.c
@@ -780,6 +780,7 @@ struct xrs700x *xrs700x_switch_alloc(struct device *base, void *devpriv)
INIT_DELAYED_WORK(&priv->mib_work, xrs700x_mib_work);
ds->ops = &xrs700x_ops;
+ ds->phylink_mac_ops = &xrs700x_phylink_mac_ops;
ds->priv = priv;
priv->dev = base;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops
2024-04-18 10:51 [PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops Russell King (Oracle)
@ 2024-04-19 11:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-19 11:20 UTC (permalink / raw)
To: Russell King
Cc: andrew, hkallweit1, george.mccollister, f.fainelli, olteanv,
davem, edumazet, kuba, pabeni, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 18 Apr 2024 11:51:21 +0100 you wrote:
> The kernel build bot identified the following mistake in the recently
> merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC
> operations") patch:
>
> drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
> 714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops
https://git.kernel.org/netdev/net-next/c/9fc31a9251de
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-19 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-18 10:51 [PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops Russell King (Oracle)
2024-04-19 11:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).