From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH net-next v2 1/5] net: dsa: remove dsa_port_phylink_mac_select_pcs()
Date: Wed, 16 Oct 2024 10:58:24 +0100 [thread overview]
Message-ID: <E1t10nQ-000AWQ-Db@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Zw-OCSv7SldjB7iU@shell.armlinux.org.uk>
There is no longer any reason to implement the mac_select_pcs()
callback in DSA. Returning ERR_PTR(-EOPNOTSUPP) is functionally
equivalent to not providing the function.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
net/dsa/port.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/net/dsa/port.c b/net/dsa/port.c
index f1e96706a701..ee0aaec4c8e0 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -1575,13 +1575,6 @@ void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp,
cpu_dp->tag_ops = tag_ops;
}
-static struct phylink_pcs *
-dsa_port_phylink_mac_select_pcs(struct phylink_config *config,
- phy_interface_t interface)
-{
- return ERR_PTR(-EOPNOTSUPP);
-}
-
static void dsa_port_phylink_mac_config(struct phylink_config *config,
unsigned int mode,
const struct phylink_link_state *state)
@@ -1604,7 +1597,6 @@ static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
}
static const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
- .mac_select_pcs = dsa_port_phylink_mac_select_pcs,
.mac_config = dsa_port_phylink_mac_config,
.mac_link_down = dsa_port_phylink_mac_link_down,
.mac_link_up = dsa_port_phylink_mac_link_up,
--
2.30.2
next prev parent reply other threads:[~2024-10-16 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:57 [PATCH net-next v2 0/5] Removing more phylink cruft Russell King (Oracle)
2024-10-16 9:58 ` Russell King (Oracle) [this message]
2024-10-16 9:58 ` [PATCH net-next v2 2/5] net: dsa: mv88e6xxx: return NULL when no PCS is present Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 3/5] net: phylink: allow mac_select_pcs() to remove a PCS Russell King (Oracle)
2024-10-17 7:00 ` Vladimir Oltean
2024-10-16 9:58 ` [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in phylink_validate_mac_and_pcs() Russell King (Oracle)
2024-10-17 7:01 ` Vladimir Oltean
2024-10-16 9:58 ` [PATCH net-next v2 5/5] net: phylink: remove "using_mac_select_pcs" Russell King (Oracle)
2024-10-17 7:06 ` Vladimir Oltean
2024-10-16 14:42 ` [PATCH net-next v2 0/5] Removing more phylink cruft Maxime Chevallier
2024-10-18 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1t10nQ-000AWQ-Db@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).