netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
	Woojung Huh <woojung.huh@microchip.com>
Subject: [PATCH RFC net-next 1/7] net: dsa: ksz: remove setting of tx_lpi parameters
Date: Tue, 10 Dec 2024 14:26:14 +0000	[thread overview]
Message-ID: <E1tL1Bm-006cn4-Gr@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Z1hPaLFlR4TW_YCr@shell.armlinux.org.uk>

dsa_user_get_eee() calls the DSA switch get_mac_eee() method followed
by phylink_ethtool_get_eee(), which goes on to call
phy_ethtool_get_eee(). This overwrites all members of the passed
ethtool_keee, which means anything written by the DSA switch
get_mac_eee() method will discarded.

Remove setting any members in ksz_get_mac_eee().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/dsa/microchip/ksz_common.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 94f9aa983ff6..9a48b4438a6d 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3480,14 +3480,6 @@ static bool ksz_support_eee(struct dsa_switch *ds, int port)
 static int ksz_get_mac_eee(struct dsa_switch *ds, int port,
 			   struct ethtool_keee *e)
 {
-	/* There is no documented control of Tx LPI configuration. */
-	e->tx_lpi_enabled = true;
-
-	/* There is no documented control of Tx LPI timer. According to tests
-	 * Tx LPI timer seems to be set by default to minimal value.
-	 */
-	e->tx_lpi_timer = 0;
-
 	return 0;
 }
 
-- 
2.30.2


  reply	other threads:[~2024-12-10 14:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10 14:25 [PATCH RFC net-next 0/7] net: dsa: cleanup EEE (part 2) Russell King (Oracle)
2024-12-10 14:26 ` Russell King (Oracle) [this message]
2024-12-12 19:38   ` [PATCH RFC net-next 1/7] net: dsa: ksz: remove setting of tx_lpi parameters Vladimir Oltean
2024-12-10 14:26 ` [PATCH RFC net-next 2/7] net: dsa: no longer call ds->ops->get_mac_eee() Russell King (Oracle)
2024-12-12 19:44   ` Vladimir Oltean
2025-01-02 17:56     ` Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 3/7] net: dsa: b53/bcm_sf2: remove b53_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 4/7] net: dsa: ksz: remove ksz_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 5/7] net: dsa: mv88e6xxx: remove mv88e6xxx_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 6/7] net: dsa: qca: remove qca8k_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 7/7] net: dsa: remove get_mac_eee() method Russell King (Oracle)
2024-12-12 19:48 ` [PATCH RFC net-next 0/7] net: dsa: cleanup EEE (part 2) Vladimir Oltean
2025-01-02 18:18   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1tL1Bm-006cn4-Gr@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).