From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vinod Koul <vkoul@kernel.org>
Subject: [PATCH net-next 3/4] net: stmmac: qcom-ethqos: remove unnecessary setting max_speed
Date: Sat, 12 Apr 2025 15:09:59 +0100 [thread overview]
Message-ID: <E1u3bYV-000EcQ-Cv@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <Z_p0LzY2_HFupWK0@shell.armlinux.org.uk>
Phylink will already limit the MAC speed according to the interface,
so if 2500BASE-X is selected, the maximum speed will be 2.5G. It is,
therefore, not necessary to set a speed limit. Remove setting
plat_dat->max_speed from this glue driver.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index cd25aea3e48f..e8d4925be21c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -676,7 +676,6 @@ static void qcom_ethqos_speed_mode_2500(struct net_device *ndev, void *data)
{
struct stmmac_priv *priv = netdev_priv(ndev);
- priv->plat->max_speed = 2500;
priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;
}
--
2.30.2
next prev parent reply other threads:[~2025-04-12 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 14:09 [PATCH net-next 0/4] net: stmmac: qcom-ethqos: simplifications Russell King (Oracle)
2025-04-12 14:09 ` [PATCH net-next 1/4] net: stmmac: qcom-ethqos: set serdes speed using serdes_speed Russell King (Oracle)
2025-04-13 21:05 ` Andrew Lunn
2025-04-12 14:09 ` [PATCH net-next 2/4] net: stmmac: qcom-ethqos: remove ethqos->speed Russell King (Oracle)
2025-04-13 21:06 ` Andrew Lunn
2025-04-12 14:09 ` Russell King (Oracle) [this message]
2025-04-13 21:07 ` [PATCH net-next 3/4] net: stmmac: qcom-ethqos: remove unnecessary setting max_speed Andrew Lunn
2025-04-12 14:10 ` [PATCH net-next 4/4] net: stmmac: qcom-ethqos: remove speed_mode_2500() method Russell King (Oracle)
2025-04-13 21:07 ` Andrew Lunn
2025-04-15 0:50 ` [PATCH net-next 0/4] net: stmmac: qcom-ethqos: simplifications patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1u3bYV-000EcQ-Cv@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).