From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E5AB2857CC for ; Fri, 15 Aug 2025 11:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755257579; cv=none; b=Pj5pPjzC114YzreWxMTvOd0Y5tgldPtTQVP+/1mUzfWW1C+37F0TGRCauCseGoQqVwQwvX0WB4Zqgji1Fuz1By9QS9y6vkDUUk4EHm2pOmknrBP8ianTf1VAL/m+8FUCgf6bUh2pQSmAtHi3pUsw2dpa2ZMbhs1xJated+j8CiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755257579; c=relaxed/simple; bh=6V1V70BQ4Q+AxwUdpm3kO/vfskRU+EpEesDYh5QUUUc=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=mMqYlt8a0dvc1uFC3vjXRl0czC71lC6CrkZ8UP8G+gUY5CBswEdM8F+2ScqnqFLdm/GVGobSYAz9Ew1lx2z8kmJNMyqAZdjdMvMQehnhA3TKVMu0BNEJzkkuDJvdxs28g3wDj5V/QGb4AnWxe3kf79MJ6kVVWIbg3auTpmyxmSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=QsXGLXZT; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="QsXGLXZT" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L5QznbrBfDm0CPpP6OtoR4rI+fX53G8dzea0w5ykP4s=; b=QsXGLXZTbdNE7RhlJrrwjNzk26 H4Bn+abraD56BuNOH4VeZZbgz/jv6LbiFIYQ6nYWs+/1KMSJSmjOhygJb23jBr8Czf1v358C3sSJR dBLJupkR86jVyo5qPX/m0xTWGmON7XpZWcgugcCviqMMQbBI4qS845d6J/FT7csXfRxCb9nZ7+iD9 DPljddYQccMSf3WEd+ma5q5tAnkTq/pbS/FhQFolFrq1PL588EuIRjGOZDxXG+AJhKKmuBUfK9KE0 zYTnXcV51G5wuJo6DaDy2UcMTE86nzoCXvmWpsqu6W8O4Yv7n9bpxzXCwhrWNShkS+OsjLnkgDJDE FpWUH3wg==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:60298 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1umsfy-000122-16; Fri, 15 Aug 2025 12:32:50 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1umsfF-008vKc-Kt; Fri, 15 Aug 2025 12:32:05 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next 4/7] net: stmmac: remove unnecessary "stmmac: wakeup enable" print Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Fri, 15 Aug 2025 12:32:05 +0100 Printing "stmmac: wakeup enable" to the kernel log isn't useful - it doesn't identify the adapter, and is effectively nothing more than a debugging print. This information can be discovered by looking at /sys/device.../power/wakeup as the device_set_wakeup_enable() call updates this sysfs file. Reviewed-by: Andrew Lunn Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index cd2fb92ac84c..58542b72cc01 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -816,7 +816,6 @@ static int stmmac_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol) } if (wol->wolopts) { - pr_info("stmmac: wakeup enable\n"); device_set_wakeup_enable(priv->device, 1); /* Avoid unbalanced enable_irq_wake calls */ if (priv->wol_irq_disabled) -- 2.30.2