From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Abhishek Chauhan <quic_abchauha@quicinc.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Alexis Lothore <alexis.lothore@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Daniel Machon <daniel.machon@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Drew Fustini <dfustini@tenstorrent.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Eric Dumazet <edumazet@google.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Furong Xu <0x1207@gmail.com>, Inochi Amaoto <inochiama@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
"Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>,
Jisheng Zhang <jszhang@kernel.org>, Kees Cook <kees@kernel.org>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Matthew Gerlach <matthew.gerlach@altera.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
netdev@vger.kernel.org, Oleksij Rempel <o.rempel@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>,
Rohan G Thomas <rohan.g.thomas@altera.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Simon Horman <horms@kernel.org>,
Song Yoong Siang <yoong.siang.song@intel.com>,
Swathi K S <swathi.ks@samsung.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH net-next 07/14] net: stmmac: remove RGMII "pcs" mode
Date: Wed, 15 Oct 2025 15:20:33 +0100 [thread overview]
Message-ID: <E1v92Mj-0000000AmH2-1LHZ@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aO-tbQCVu47R3izM@shell.armlinux.org.uk>
Remove the RGMII "pcs" code in stmmac_check_pcs_mode() due to:
1) This should never have been conditional on a PCS being present, as
when a core is synthesised using only RGMII, the PCS won't be present
and priv->dma_cap.pcs will be false. Only multi-interface cores which
have a PCS present would have detected RGMII.
2) STMMAC_PCS_RGMII has no effect since the broken netif_carrier and
ethtool code was removed.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 -
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 14 +++-----------
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
index 33aeac5666f4..ed5e207ffdba 100644
--- a/drivers/net/ethernet/stmicro/stmmac/common.h
+++ b/drivers/net/ethernet/stmicro/stmmac/common.h
@@ -270,7 +270,6 @@ struct stmmac_safety_stats {
#define FLOW_AUTO (FLOW_TX | FLOW_RX)
/* PCS defines */
-#define STMMAC_PCS_RGMII (1 << 0)
#define STMMAC_PCS_SGMII (1 << 1)
#define SF_DMA_MODE 1 /* DMA STORE-AND-FORWARD Operation Mode */
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 6252e30ff82d..d440b1c2b7ff 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1087,17 +1087,9 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
{
int interface = priv->plat->phy_interface;
- if (priv->dma_cap.pcs) {
- if ((interface == PHY_INTERFACE_MODE_RGMII) ||
- (interface == PHY_INTERFACE_MODE_RGMII_ID) ||
- (interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
- (interface == PHY_INTERFACE_MODE_RGMII_TXID)) {
- netdev_dbg(priv->dev, "PCS RGMII support enabled\n");
- priv->hw->pcs = STMMAC_PCS_RGMII;
- } else if (interface == PHY_INTERFACE_MODE_SGMII) {
- netdev_dbg(priv->dev, "PCS SGMII support enabled\n");
- priv->hw->pcs = STMMAC_PCS_SGMII;
- }
+ if (priv->dma_cap.pcs && interface == PHY_INTERFACE_MODE_SGMII) {
+ netdev_dbg(priv->dev, "PCS SGMII support enabled\n");
+ priv->hw->pcs = STMMAC_PCS_SGMII;
}
}
--
2.47.3
next prev parent reply other threads:[~2025-10-15 14:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 14:19 [PATCH net-next 00/14] net: stmmac: phylink PCS conversion Russell King (Oracle)
2025-10-15 14:20 ` [PATCH net-next 01/14] net: stmmac: remove broken PCS code Russell King (Oracle)
2025-10-15 20:44 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 02/14] net: stmmac: remove xstats.pcs_* members Russell King (Oracle)
2025-10-15 20:45 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 03/14] net: stmmac: remove SGMII/RGMII/SMII interrupt handling Russell King (Oracle)
2025-10-15 20:47 ` Andrew Lunn
2025-10-15 21:35 ` Andrew Lunn
2025-10-15 22:12 ` Russell King (Oracle)
2025-10-16 13:07 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 04/14] net: stmmac: remove PCS "mode" pause handling Russell King (Oracle)
2025-10-15 20:48 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 05/14] net: stmmac: remove unused PCS loopback support Russell King (Oracle)
2025-10-15 20:50 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 06/14] net: stmmac: remove hw->ps xxx_core_init() hardware setup Russell King (Oracle)
2025-10-15 14:20 ` Russell King (Oracle) [this message]
2025-10-15 20:53 ` [PATCH net-next 07/14] net: stmmac: remove RGMII "pcs" mode Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 08/14] net: stmmac: move reverse-"pcs" mode setup to stmmac_check_pcs_mode() Russell King (Oracle)
2025-10-15 20:55 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 09/14] net: stmmac: simplify stmmac_check_pcs_mode() Russell King (Oracle)
2025-10-15 20:56 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 10/14] net: stmmac: hw->ps becomes hw->reverse_sgmii_enable Russell King (Oracle)
2025-10-15 20:57 ` Andrew Lunn
2025-10-15 14:20 ` [PATCH net-next 11/14] net: stmmac: do not require snps,ps-speed for SGMII Russell King (Oracle)
2025-10-15 21:00 ` Andrew Lunn
2025-10-15 21:26 ` Andrew Lunn
2025-10-15 21:48 ` Russell King (Oracle)
2025-10-16 13:03 ` Andrew Lunn
2025-10-16 13:51 ` Russell King (Oracle)
2025-10-15 14:20 ` [PATCH net-next 12/14] net: stmmac: only call stmmac_pcs_ctrl_ane() for integrated SGMII PCS Russell King (Oracle)
2025-10-15 21:01 ` Andrew Lunn
2025-10-15 14:21 ` [PATCH net-next 13/14] net: stmmac: provide PCS initialisation hook Russell King (Oracle)
2025-10-15 21:11 ` Andrew Lunn
2025-10-15 21:32 ` Russell King (Oracle)
2025-10-15 14:21 ` [PATCH net-next 14/14] net: stmmac: convert to phylink PCS support Russell King (Oracle)
2025-10-15 21:31 ` Andrew Lunn
2025-10-15 21:57 ` Russell King (Oracle)
2025-10-16 13:05 ` Andrew Lunn
2025-10-15 15:10 ` [PATCH net-next 00/14] net: stmmac: phylink PCS conversion Russell King (Oracle)
2025-10-16 7:44 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1v92Mj-0000000AmH2-1LHZ@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=dfustini@tenstorrent.com \
--cc=edumazet@google.com \
--cc=eleanor15x@gmail.com \
--cc=emil.renner.berthing@canonical.com \
--cc=faizal.abdul.rahim@linux.intel.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=inochiama@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_abchauha@quicinc.com \
--cc=rohan.g.thomas@altera.com \
--cc=shenwei.wang@nxp.com \
--cc=swathi.ks@samsung.com \
--cc=vkoul@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=yong.liang.choong@linux.intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).