From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: [PATCH net-next v2 7/8] net: stmmac: use != rather than ^ for comparing dev_id
Date: Fri, 24 Oct 2025 13:49:35 +0100 [thread overview]
Message-ID: <E1vCHEd-0000000BPUG-3cS7@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aPt1l6ocBCg4YlyS@shell.armlinux.org.uk>
Use the more usual not-equals rather than exclusive-or operator when
comparing the dev_id in stmmac_hwif_find().
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
index 6c5429f37cae..187ae582a933 100644
--- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
@@ -314,7 +314,7 @@ stmmac_hwif_find(enum dwmac_core_type core_type, u8 snpsver, u8 dev_id)
if (snpsver < entry->min_id)
continue;
if (core_type == DWMAC_CORE_XGMAC &&
- (dev_id ^ entry->dev_id))
+ dev_id != entry->dev_id)
continue;
return entry;
--
2.47.3
next prev parent reply other threads:[~2025-10-24 12:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 12:48 [PATCH net-next 0/8] net: stmmac: hwif.c cleanups Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 1/8] net: stmmac: move version handling into own function Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 2/8] net: stmmac: simplify stmmac_get_version() Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 3/8] net: stmmac: consolidate version reading and validation Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 4/8] net: stmmac: move stmmac_get_*id() into stmmac_get_version() Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 5/8] net: stmmac: use FIELD_GET() for version register Russell King (Oracle)
2025-10-24 12:49 ` [PATCH net-next v2 6/8] net: stmmac: provide function to lookup hwif Russell King (Oracle)
2025-10-24 12:49 ` Russell King (Oracle) [this message]
2025-10-24 12:49 ` [PATCH net-next v2 8/8] net: stmmac: reorganise stmmac_hwif_init() Russell King (Oracle)
2025-10-24 20:22 ` [PATCH net-next 0/8] net: stmmac: hwif.c cleanups Mohd Ayaan Anwar
2025-10-28 23:42 ` Jakub Kicinski
2025-10-28 23:54 ` Russell King (Oracle)
2025-10-28 23:57 ` Russell King (Oracle)
2025-10-29 0:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1vCHEd-0000000BPUG-3cS7@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).