netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Vladimir Zapolskiy <vz@mleia.com>
Subject: [PATCH net-next 4/9] net: stmmac: lpc18xx: validate phy_intf_sel
Date: Thu, 06 Nov 2025 11:23:27 +0000	[thread overview]
Message-ID: <E1vGy5P-0000000DhQJ-0Oi3@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aQyEs4DAZRWpAz32@shell.armlinux.org.uk>

Validate the phy_intf_sel value rather than the PHY interface mode.
This will allow us to transition to the ->set_phy_intf_sel() method.
Note that this will allow GMII as well as MII as the phy_intf_sel
value is the same for both.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c
index 0f6be2a17e65..ec60968113b8 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c
@@ -47,14 +47,13 @@ static int lpc18xx_dwmac_probe(struct platform_device *pdev)
 		return PTR_ERR(reg);
 	}
 
-	if (plat_dat->phy_interface != PHY_INTERFACE_MODE_MII &&
-	    plat_dat->phy_interface != PHY_INTERFACE_MODE_RMII) {
+	ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
+	if (ethmode != PHY_INTF_SEL_GMII_MII &&
+	    ethmode != PHY_INTF_SEL_RMII) {
 		dev_err(&pdev->dev, "Only MII and RMII mode supported\n");
 		return -EINVAL;
 	}
 
-	ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
-
 	regmap_update_bits(reg, LPC18XX_CREG_CREG6,
 			   LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);
 
-- 
2.47.3


  parent reply	other threads:[~2025-11-06 11:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 11:21 [PATCH net-next 0/9] net: stmmac: lpc18xx and sti: convert to set_phy_intf_sel() Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 1/9] net: stmmac: lpc18xx: convert to PHY_INTF_SEL_x Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 2/9] net: stmmac: lpc18xx: use PHY_INTF_SEL_x directly Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 3/9] net: stmmac: lpc18xx: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-06 11:23 ` Russell King (Oracle) [this message]
2025-11-06 11:23 ` [PATCH net-next 5/9] net: stmmac: lpc18xx: use ->set_phy_intf_sel() Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 6/9] net: stmmac: sti: use PHY_INTF_SEL_x to select PHY interface Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 7/9] net: stmmac: sti: use PHY_INTF_SEL_x directly Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 8/9] net: stmmac: sti: use stmmac_get_phy_intf_sel() Russell King (Oracle)
2025-11-06 11:23 ` [PATCH net-next 9/9] net: stmmac: sti: use ->set_phy_intf_sel() Russell King (Oracle)
2025-11-08  3:20 ` [PATCH net-next 0/9] net: stmmac: lpc18xx and sti: convert to set_phy_intf_sel() patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1vGy5P-0000000DhQJ-0Oi3@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).