From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB22C39B496 for ; Tue, 3 Feb 2026 10:01:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770112896; cv=none; b=cMmKUD0hgJ402nprp8UntyxJ7+1P1/nKiVqJUUUoW0jLVdlOjHRlBpW9FUmj3OFGzOH4VLiSNXaqyv3LXbsRahBLUtmhYNp6gY+JRf3zMkPktkGTBMXTjqyWyVyYVnR0GXAPp25mAgpIlX/QaDxC6hxttz0F3o9Tr6TNo42TEqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770112896; c=relaxed/simple; bh=u89I6KD6qvHXBGtoOq6YNPVbmJUH26ru0FQq596nrh0=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=YGDCMVYeDraqRsmVBDg8JR88klTD0SeUc85KpHqQO7xjmIkgRaL57gYrjL6wcFa5CgLznmsIWPDycUTk21tGs4mmv5BKLjS6tlFxc407gWBlkIYPQU8lCygMcjFYmNnG9US4Xqi0ZmtZ7OtuyFp6ssCRDLuEsCtc76uMR0yIows= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=RgBvXZX3; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="RgBvXZX3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+glT1WUCuKKRwLLSyDdKdz7/iH8B4iVFWpjJ7rAM32I=; b=RgBvXZX3BO0h4gx+wAS1NsQHr0 wxM1Nx375bb/gzMAB8DAwmbHT8eBprkmKNQQLUj84gIHxeU817sFFR+KRvzmRxw8/fkBCtTQAemJV 8Q9kUiLj51RCcvAd3ShmWlG+YIE8bCL+uVQ4opsTe+jsatHsFho9HqBc9z2lhiDFtG8OfyHp1DsKF 1Qgn17OeG5AmgG5yS9TCt6EeUYDJpr5wXvHQbwbj4875y4FEw4NVjTOLw8IL2I5hn47UCv0KS2oRY jWAtub3QW/+VRmpS3GSs3sce3hz7LrqpYzWOVBOk4PN5pF5NHa8+/FamY3l5Hei3DN+YsAxY5M+G+ fIEYMvig==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:40622 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vnDDp-000000004xC-2P37; Tue, 03 Feb 2026 10:01:25 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vnDDo-00000007Xx9-3RZ8; Tue, 03 Feb 2026 10:01:24 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next 3/4] net: stmmac: add missing serdes power down in error paths Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Tue, 03 Feb 2026 10:01:24 +0000 The open path is missing cleanup of a successful serdes power up if stmmac_hw_setup() or stmmac_request_irq() fails. stmmac_resume() is also missing cleanup of the serdes power up if stmmac_hw_setup() fails. Add the missing cleanups. Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 9efdde915229..05b0b080bade 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4137,7 +4137,7 @@ static int __stmmac_open(struct net_device *dev, if (!(priv->plat->flags & STMMAC_FLAG_SERDES_UP_AFTER_PHY_LINKUP)) { ret = stmmac_legacy_serdes_power_up(priv); if (ret < 0) - goto init_error; + return ret; } ret = stmmac_hw_setup(dev); @@ -4170,6 +4170,7 @@ static int __stmmac_open(struct net_device *dev, stmmac_release_ptp(priv); init_error: + stmmac_legacy_serdes_power_down(priv); return ret; } @@ -8273,6 +8274,7 @@ int stmmac_resume(struct device *dev) ret = stmmac_hw_setup(ndev); if (ret < 0) { netdev_err(priv->dev, "%s: Hw setup failed\n", __func__); + stmmac_legacy_serdes_power_down(priv); mutex_unlock(&priv->lock); rtnl_unlock(); return ret; -- 2.47.3