From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH RFC net-next v3 6/8] net: stmmac: qcom-ethqos: enable inband mode for SGMII
Date: Mon, 09 Mar 2026 11:20:52 +0000 [thread overview]
Message-ID: <E1vzYfM-0000000CZz0-3HXq@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <aa6sofjFxyi2nkpr@shell.armlinux.org.uk>
qcom-ethqos is manually enabling the PCS ANE bit for SGMII modes while
phylink remains in outband mode. With support for SGMII inband mode now
supported by the stmmac PCS code, switch phylink to use inband mode for
SGMII. Phylink will switch back to outband mode for 2500BASE-X since the
PCS code reports no BASE-X AN support.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index f4b63544895e..1f38e4ee0195 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -831,6 +831,8 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
plat_dat->flags |= STMMAC_FLAG_SERDES_SUPPORTS_2500M;
}
+ plat_dat->mdio_bus_data->default_an_inband = true;
+
/* Enable TSO on queue0 and enable TBS on rest of the queues */
for (i = 1; i < plat_dat->tx_queues_to_use; i++)
plat_dat->tx_queues_cfg[i].tbs_en = 1;
--
2.47.3
next prev parent reply other threads:[~2026-03-09 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 11:18 [PATCH RFC net-next v3 0/8] net: stmmac: improve PCS support Russell King (Oracle)
2026-03-09 11:20 ` [PATCH RFC net-next v3 1/8] net: stmmac: add struct stmmac_pcs_info Russell King (Oracle)
2026-03-09 11:20 ` [PATCH RFC net-next v3 2/8] net: stmmac: add support for reading inband SGMII status Russell King (Oracle)
2026-03-09 11:20 ` [PATCH RFC net-next v3 3/8] net: stmmac: add BASE-X support to integrated PCS Russell King (Oracle)
2026-03-09 11:20 ` [PATCH RFC net-next v3 4/8] net: stmmac: use integrated PCS for BASE-X modes Russell King (Oracle)
2026-03-09 11:20 ` [PATCH RFC net-next v3 5/8] net: stmmac: qcom-ethqos: enable 2500BASE-X Russell King (Oracle)
2026-03-09 11:20 ` Russell King (Oracle) [this message]
2026-03-09 11:20 ` [PATCH RFC net-next v3 7/8] net: stmmac: configure SGMII AN control according to phylink Russell King (Oracle)
2026-03-09 11:21 ` [PATCH RFC net-next v3 8/8] net: stmmac: report PCS configuration changes Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1vzYfM-0000000CZz0-3HXq@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox