[PATCH net-next] net: phylink: add debug for phy_config_inband()

[PATCH net-next] net: phylink: add debug for phy_config_inband()

[Russell King (Oracle)]

Add debug for the phy_config_inband() call so we can see which inband
modes are being configured at the PHY.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
 drivers/net/phy/phylink.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 59bcc69b6c39..1c178038e6f1 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -1341,6 +1341,13 @@ static void phylink_major_config(struct phylink *pl, bool restart,
 	}
 
 	if (pl->phydev && pl->phy_ib_mode) {
+		phylink_dbg(pl, "configuring PHY for inband%s%s%s\n",
+			    pl->phy_ib_mode & LINK_INBAND_DISABLE ?
+				" disable" : "",
+			    pl->phy_ib_mode & LINK_INBAND_ENABLE ?
+				" enable" : "",
+			    pl->phy_ib_mode & LINK_INBAND_BYPASS ?
+				" bypass" : "");
 		err = phy_config_inband(pl->phydev, pl->phy_ib_mode);
 		if (err < 0) {
 			phylink_err(pl, "phy_config_inband: %pe\n",
-- 
2.47.3

Re: [PATCH net-next] net: phylink: add debug for phy_config_inband()

[Maxime Chevallier]

On 18/03/2026 09:27, Russell King (Oracle) wrote:
> Add debug for the phy_config_inband() call so we can see which inband
> modes are being configured at the PHY.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Ah, useful indeed !

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

> ---
>  drivers/net/phy/phylink.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 59bcc69b6c39..1c178038e6f1 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1341,6 +1341,13 @@ static void phylink_major_config(struct phylink *pl, bool restart,
>  	}
>  
>  	if (pl->phydev && pl->phy_ib_mode) {
> +		phylink_dbg(pl, "configuring PHY for inband%s%s%s\n",
> +			    pl->phy_ib_mode & LINK_INBAND_DISABLE ?
> +				" disable" : "",
> +			    pl->phy_ib_mode & LINK_INBAND_ENABLE ?
> +				" enable" : "",
> +			    pl->phy_ib_mode & LINK_INBAND_BYPASS ?
> +				" bypass" : "");
>  		err = phy_config_inband(pl->phydev, pl->phy_ib_mode);
>  		if (err < 0) {
>  			phylink_err(pl, "phy_config_inband: %pe\n",

Re: [PATCH net-next] net: phylink: add debug for phy_config_inband()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 18 Mar 2026 08:27:44 +0000 you wrote:
> Add debug for the phy_config_inband() call so we can see which inband
> modes are being configured at the PHY.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Here is the summary with links:
  - [net-next] net: phylink: add debug for phy_config_inband()
    https://git.kernel.org/netdev/net-next/c/eb2415854f3b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html