From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net-next 2/6] net: stmmac: move first xmit descriptor SARC and TBS config
Date: Fri, 20 Mar 2026 16:47:17 +0000 [thread overview]
Message-ID: <E1w3d0H-0000000DfLp-0gIx@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <ab15_JvLGFtUH_3x@shell.armlinux.org.uk>
Move the first transmit descriptor's SARC and TBS configuration
alongside the code which populates the first descriptor, which helps
to keep all the code specific to that descriptor together.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 0586ab13cc48..3d94f632fca6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4799,6 +4799,16 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
0, last_segment, skb->len);
}
+ if (priv->sarc_type)
+ stmmac_set_desc_sarc(priv, first_desc, priv->sarc_type);
+
+ if (tx_q->tbs & STMMAC_TBS_EN) {
+ struct timespec64 ts = ns_to_timespec64(skb->tstamp);
+
+ tbs_desc = &tx_q->dma_entx[first_entry];
+ stmmac_set_desc_tbs(priv, tbs_desc, ts.tv_sec, ts.tv_nsec);
+ }
+
for (i = 0; i < nfrags; i++) {
const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
unsigned int frag_size = skb_frag_size(frag);
@@ -4885,16 +4895,6 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
u64_stats_inc(&txq_stats->q.tx_set_ic_bit);
u64_stats_update_end(&txq_stats->q_syncp);
- if (priv->sarc_type)
- stmmac_set_desc_sarc(priv, first_desc, priv->sarc_type);
-
- if (tx_q->tbs & STMMAC_TBS_EN) {
- struct timespec64 ts = ns_to_timespec64(skb->tstamp);
-
- tbs_desc = &tx_q->dma_entx[first_entry];
- stmmac_set_desc_tbs(priv, tbs_desc, ts.tv_sec, ts.tv_nsec);
- }
-
/* Set the OWN bit on the first descriptor now that all descriptors
* for this skb are populated.
*/
--
2.47.3
next prev parent reply other threads:[~2026-03-20 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 16:46 [PATCH net-next 0/6] net: stmmac: cleanup stmmac_xmit() Russell King (Oracle)
2026-03-20 16:47 ` [PATCH net-next 1/6] net: stmmac: move stmmac_xmit() skb head handling Russell King (Oracle)
2026-03-20 16:47 ` Russell King (Oracle) [this message]
2026-03-20 16:47 ` [PATCH net-next 3/6] net: stmmac: move stmmac_xmit() first entry index code Russell King (Oracle)
2026-03-20 16:47 ` [PATCH net-next 4/6] net: stmmac: move stmmac_xmit() initial variable init Russell King (Oracle)
2026-03-20 16:47 ` [PATCH net-next 5/6] net: stmmac: use first_desc for TBS Russell King (Oracle)
2026-03-20 16:47 ` [PATCH net-next 6/6] net: stmmac: elminate tbs_desc in stmmac_xmit() Russell King (Oracle)
2026-03-20 19:44 ` [PATCH net-next 0/6] net: stmmac: cleanup stmmac_xmit() Maxime Chevallier
2026-03-24 11:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1w3d0H-0000000DfLp-0gIx@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox