From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9235D33CEB5; Fri, 27 Mar 2026 08:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774601093; cv=none; b=h4WNDwKLP1OotKJS6f8jOvQEFX17gQDv5H9H5yigmY/aktiWFL/RE+sU3fVHLLLfCLDZxHMVxTwoJhO1wx8/fC4mYbL6bcr/qDzt9lcXKdzsstBdGFUgBL3+ZZs6M74CIAueXNM2/+jaGcRnghi5FhRmvVWp7iVuhktY6gh71/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774601093; c=relaxed/simple; bh=8f0U/S1xps8HWxHbFLIcnkyD267xp8BelC9dIdVpjzc=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=ED8dnZBcouO31Lc5E+4QBuTKCTII/HZG6dy8OqNw6Pu+oYjKiX7ThQyw30s2BkhbKXJKjQN8UiQwebSxpY5CfFcAB3//6/9y6NUVnSJl5cQzI1fbksd9V//I31zf+7eHkLY2/oA/MxIfSGk98pxbp1P8pWjunXNnkoQ7rKAxACw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=0RI78cVQ; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="0RI78cVQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JlF/V14PwB75IsbEuhaJfwWNwWzBEh6C98Euf38uuoQ=; b=0RI78cVQOFbDkwM5SB0Kga7EPE YwEVJ1p5CZaWpSZDXommseI6/EYomQo72SXo5S62kdRyWZCsKruRANJUx7L/pZ9e9f19ls1Ty85Lp Nn90d9CV4MTpzUWHe5SmSuOWH1XujzWfPzKBwboCzM3Jv7nhvWqMiH9lTQ4CRSARpJo4bhedB7wwu hH8nLEs5ZUeFWaWIpgrx89vzczjN5jzXAA5nQEBVOZeVH9yH4KpF1C9FCQbfSiyqAM5PioVuUoz5/ 7iF5CAnVO3+j9iEt2PZr3fM4fCP+UaOTI1RpYNWMHxwrI/fnj5jQBqrJtx3JIxc3wID8hcPhSHLT4 t3I0Uc+w==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:51102 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w62o1-000000005sI-1Sah; Fri, 27 Mar 2026 08:44:37 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w62ny-0000000E3D8-38Yp; Fri, 27 Mar 2026 08:44:34 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next v2 14/15] net: stmmac: qcom-ethqos: correct prg_rclk_dly comment Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Fri, 27 Mar 2026 08:44:34 +0000 The comment for calculating the prg_rclk_dly value is incorrect as it omits the brackets around the divisor. Add the brackets to allow the reader to correctly evaluate the value. Validated with the values given in the driver. Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index 9dae40c27903..667676c29a95 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -450,8 +450,10 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) rgmii_setmask(ethqos, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN, SDCC_HC_REG_DDR_CONFIG); } else { - /* PRG_RCLK_DLY = TCXO period * TCXO_CYCLES_CNT / 2 * RX delay ns, - * in practice this becomes PRG_RCLK_DLY = 52 * 4 / 2 * RX delay ns + /* PRG_RCLK_DLY = TCXO period * TCXO_CYCLES_CNT / + * (2 * RX delay ns), + * in practice this becomes PRG_RCLK_DLY = 52 * 4 / + * (2 * RX delay ns) */ if (ethqos->has_emac_ge_3) { /* 0.9 ns */ -- 2.47.3