From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9DD9372693 for ; Sat, 28 Mar 2026 21:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774733855; cv=none; b=f7Y2nNnT2XgXpYRKYHrcBun60o/8WRHSmd1bd8KzRfTbA13NnW8yPmKD1gWEiRuSRjcoXnWTtAspBRNRaqm78FDZB89rmOZEFzG37DvSoSte+66nTbGX8W0k71BHNwB7m7D6ybv+Q7zqM/rASlgyEYzNJ4LQcb1Y4Y9Ri53Weo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774733855; c=relaxed/simple; bh=zyGgkLbfyuN5fjLV0itZd5aBxbj0Tnkoo8P+vUpXmUw=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=s+uHkbZgXPougJA9qCu3bqlXsX4abvBKSV/rDA6u5FvIIsbtfn8fm2XvNtLNjQ3ElNaedZt+Plk0iu61GxCMcPuQb8IonKdQLtpkNENE3RErY90E5nYaHzzKntZHxt8r2rVaNWvzA2PZckO2JC2umk33Zu/MQkYmjzu6bCkOpAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=X6ncgmiq; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="X6ncgmiq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mAKrOCApQzZu2zjOdNYoweFwV7e0x+wpN1tQch7jZX8=; b=X6ncgmiqT8+A6FjjlkaLMVhA+6 Vd1/NoHB/v/6tciiT5mrhH0oQykrLBJ9GET2Izdc/o/BHyhZKcewlwp5B+6iTVL0abrA4mhsm3MRs f60U481DoOjuCFDWx0ZZ+Ep6ZkLswRe3MMz7xhyPIyupCKzeUe734oxKhwuaY5D0k35AS8TlfFm0f raeGF85p2MSMlzMvHmPXr60A8AQlQTnoB0C22TWa8p9yooDknF5aAmj8iDSSUjsv9cSkdWDxRljnf oV/KR7jC5ksDQXfDCYIwDF69w7+EzeNvARavEIeglsMnhDMUwkCrf7z5sTe8n+5mAS5tjJ6006irq NE091BoA==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:56392 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w6bLQ-000000007Tz-0swP; Sat, 28 Mar 2026 21:37:24 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w6bLO-0000000ELuR-3IhN; Sat, 28 Mar 2026 21:37:22 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Ong Boon Leong , Paolo Abeni Subject: [PATCH net-next 09/10] net: stmmac: add warning when TSO is requested but unsupported Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Sat, 28 Mar 2026 21:37:22 +0000 Add a warning message if TSO is requested by the platform glue code but the core wasn't configured for TSO. Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3bfa4bbe857f..c61ce1282368 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4388,8 +4388,10 @@ static void stmmac_set_gso_features(struct net_device *ndev) if (!(priv->plat->flags & STMMAC_FLAG_TSO_EN)) return; - if (!priv->dma_cap.tsoen) + if (!priv->dma_cap.tsoen) { + dev_warn(priv->device, "platform requests unsupported TSO\n"); return; + } ndev->hw_features |= NETIF_F_TSO | NETIF_F_TSO6; if (priv->plat->core_type == DWMAC_CORE_GMAC4) -- 2.47.3