From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F263C376BCD for ; Wed, 1 Apr 2026 07:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028111; cv=none; b=Q+F6tcxCqghkLzhCSlb5O2OgqNoQ0kgbLebcyHN+ez0M+qyGlTFk/jVDVWIKAFeUVMnSuAsmITZY+/K7EveYIhZs6h0LxeDkhq9Zef28RXmdiVLes32BWcpKOf8zJLRCdnqag5QbocZ2QpXd/scS5Zv9wVevHiZRet+goeC1bRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028111; c=relaxed/simple; bh=EPzI7asSoluFOcbu22r5JiCkDx3b6T0eRTVXzL1VAMI=; h=In-Reply-To:References:From:To:Cc:Subject:MIME-Version: Content-Disposition:Content-Type:Message-Id:Date; b=JyQYDmZzJKN6r6F9skRhCbu16YQ1jHt5rtE6JjGau/yFejP/fCRAEGSbjWV+6RYS+xb72fARUU7+HXG+2259M1fciVJV8hyAFlC6IPA3Qs4lpqQtE6n+QX0PpuDyLM+ndl14D2CDp61qHRH/+AWjTigrUmR2VPGVmx1KYVmGago= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=GqNvIqZo; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="GqNvIqZo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9/5jetOXR4x4aaSx1QBWBlZ8VD7jqIHKoH/Y1tbFC5A=; b=GqNvIqZoA5gd71eKX/QcHVN/Ne 6vOstvxdHEkR/WksCL4ZEG5MFw6rLXC3FFX0/h+IBaVRdWl1AlzdHSFwYyhCBGNtb259KPE8NJR2e H1vMmv5rkqBJ3vd0TSNKIgCndWc4kKAA4KWtk18fMzNkxf0xOrsIFEs0p9c8OY1jdUfw5Z9Nps5Wq OZZijREV9nIu4j+hwJ5g+lj3r1FpAPd5injy3CSH2Gfn4r9NiVrZpzrAK4WH+0fCDQ6xsSTDx3P6q 7wjAIfwazR6WjigZwtDfCoMzlPAwlljRxzole+14iAraJKnTuq3E6kCT7Vcr+gcFzmAlhgd9i2GOH yV+9zWlA==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:41312 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w7ptU-000000002gu-3v66; Wed, 01 Apr 2026 08:21:41 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w7ptT-0000000EatI-3feh; Wed, 01 Apr 2026 08:21:39 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Ong Boon Leong , Paolo Abeni Subject: [PATCH net-next v2 06/14] net: stmmac: add GSO MSS checks Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" Message-Id: Sender: Russell King Date: Wed, 01 Apr 2026 08:21:39 +0100 Add GSO MSS checks to stmmac_features_check(). Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 031ffb78f40d..b4cc34dd0d76 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -4391,12 +4391,19 @@ static size_t stmmac_tso_header_size(struct sk_buff *skb) * * While IPv4 is limited to MAC+VLAN+IPv4+ext+TCP+ext = 138 bytes, the IPv6 * extension headers aren't similarly limited. + * + * Fall back to software GSO for these skbs. Also check that the MSS is >= + * the recommended 64 bytes (documented in ETH_DMACxCR register description), + * and that a the header plus MSS is not larger than 16383 (documented in + * "Building the Descriptor and the packet for the TSO feature"). */ static bool stmmac_tso_valid_packet(struct sk_buff *skb) { size_t header_len = stmmac_tso_header_size(skb); + unsigned int gso_size = skb_shinfo(skb)->gso_size; - return header_len <= 1023; + return header_len <= 1023 && gso_size >= 64 && + header_len + gso_size < 16383; } /** -- 2.47.3