From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Khemka Subject: Re: [PATCH v2] net/ncsi: Add NCSI OEM command support Date: Sat, 29 Sep 2018 01:20:56 +0000 Message-ID: References: <20180929010602.1025909-1-vijaykhemka@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 To: "Justin . Lee1 @ Dell . com" , "joel @ jms . id . au" , "linux-aspeed @ lists . ozlabs . org" , "openbmc @ lists . ozlabs . org" , Sai Dasari , "netdev @ vger . kernel . org" , "christian @ cmd . nu" , Samuel Mendoza-Jonas Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34890 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbeI2Hrd (ORCPT ); Sat, 29 Sep 2018 03:47:33 -0400 In-Reply-To: <20180929010602.1025909-1-vijaykhemka@fb.com> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: DQoNCu+7vz4gT24gOS8yOC8xOCwgNjowNyBQTSwgIlZpamF5IEtoZW1rYSIgPHZpamF5a2hlbWth QGZiLmNvbT4gd3JvdGU6DQoNCiA+ICAgVGhpcyBwYXRjaCBhZGRzIE9FTSBjb21tYW5kcyBhbmQg cmVzcG9uc2UgaGFuZGxpbmcuIEl0IGFsc28gZGVmaW5lcyBPRU0NCiA+ICAgY29tbWFuZCBhbmQg cmVzcG9uc2Ugc3RydWN0dXJlIGFzIHBlciBOQ1NJIHNwZWNpZmljYXRpb24gYWxvbmcgd2l0aCBp dHMNCiA+ICAgaGFuZGxlcnMuDQogPiAgIA0KID4gICBuY3NpX2NtZF9oYW5kbGVyX29lbTogVGhp cyBpcyBhIGdlbmVyaWMgY29tbWFuZCByZXF1ZXN0IGhhbmRsZXIgZm9yIE9FTQ0KID4gICBjb21t YW5kcw0KID4gICBuY3NpX3JzcF9oYW5kbGVyX29lbTogVGhpcyBpcyBhIGdlbmVyaWMgcmVzcG9u c2UgaGFuZGxlciBmb3IgT0VNIGNvbW1hbmRzDQogICANCiAgVGhpcyBpcyBhIGdlbmVyaWMgcGF0 Y2ggZm9yIE9FTSBjb21tYW5kIGhhbmRsaW5nLCBUaGVyZSB3aWxsIGJlIGFub3RoZXIgcGF0Y2gg DQogIGZvbGxvd2luZyB0aGlzIHRvIGhhbmRsZSBzcGVjaWZpYyBPRU0gY29tbWFuZHMgZm9yIGVh Y2ggdmVuZG9yLiBDdXJyZW50bHkgSSBoYXZlDQogIGRlZmluZWQgMiB2ZW5kb3IvbWFudWZhY3R1 cmVyIGlkIGJlbG93IGluIGludGVybmFsLmgsIG1vcmUgY2FuIGJlIGFkZGVkIGhlcmUgZm9yDQog IG90aGVyIHZlbmRvcnMuIEkgaGF2ZSBub3QgZGVmaW5lZCBuY3NpX3JzcF9vZW1faGFuZGxlciBp biB0aGlzIHBhdGNoIGFzIHRoZXkgYXJlIA0KICBOVUxMLCBidXQgdGhlcmUgd2lsbCBiZSBhIGRl ZmluZWQgaGFuZGxlcnMgZm9yIGVhY2ggdmVuZG9yIGluIG5leHQgcGF0Y2guIA0KIA0KICAgIFNp Z25lZC1vZmYtYnk6IFZpamF5IEtoZW1rYSA8dmlqYXlraGVta2FAZmIuY29tPg0KICAgIC0tLQ0K ICAgICBuZXQvbmNzaS9pbnRlcm5hbC5oIHwgIDQgKysrKw0KICAgICBuZXQvbmNzaS9uY3NpLWNt ZC5jIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQ0KICAgICBuZXQvbmNzaS9u Y3NpLXBrdC5oIHwgMTYgKysrKysrKysrKysrKysrKw0KICAgICBuZXQvbmNzaS9uY3NpLXJzcC5j IHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCiAgICAg NCBmaWxlcyBjaGFuZ2VkLCA5MSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0KICAgIA0K ICAgIGRpZmYgLS1naXQgYS9uZXQvbmNzaS9pbnRlcm5hbC5oIGIvbmV0L25jc2kvaW50ZXJuYWwu aA0KICAgIGluZGV4IDgwNTVlMzk2NWNlZi4uYzE2Y2I3MjIzMDY0IDEwMDY0NA0KICAgIC0tLSBh L25ldC9uY3NpL2ludGVybmFsLmgNCiAgICArKysgYi9uZXQvbmNzaS9pbnRlcm5hbC5oDQogICAg QEAgLTY4LDYgKzY4LDEwIEBAIGVudW0gew0KICAgICAJTkNTSV9NT0RFX01BWA0KICAgICB9Ow0K ICAgICANCiAgICArLyogT0VNIFZlbmRvciBNYW51ZmFjdHVyZSBJRCAqLw0KICAgICsjZGVmaW5l IE5DU0lfT0VNX01GUl9NTFhfSUQgICAgICAgICAgICAgMHg4MTE5DQogICAgKyNkZWZpbmUgTkNT SV9PRU1fTUZSX0JDTV9JRCAgICAgICAgICAgICAweDExM2QNCiAgICArDQogICAgIHN0cnVjdCBu Y3NpX2NoYW5uZWxfdmVyc2lvbiB7DQogICAgIAl1MzIgdmVyc2lvbjsJCS8qIFN1cHBvcnRlZCBC Q0QgZW5jb2RlZCBOQ1NJIHZlcnNpb24gKi8NCiAgICAgCXUzMiBhbHBoYTI7CQkvKiBTdXBwb3J0 ZWQgQkNEIGVuY29kZWQgTkNTSSB2ZXJzaW9uICovDQogICAgZGlmZiAtLWdpdCBhL25ldC9uY3Np L25jc2ktY21kLmMgYi9uZXQvbmNzaS9uY3NpLWNtZC5jDQogICAgaW5kZXggNzU2N2NhNjNhYWUy Li4yZjk4NTMzZWJhNDYgMTAwNjQ0DQogICAgLS0tIGEvbmV0L25jc2kvbmNzaS1jbWQuYw0KICAg ICsrKyBiL25ldC9uY3NpL25jc2ktY21kLmMNCiAgICBAQCAtMjExLDYgKzIxMSwyNiBAQCBzdGF0 aWMgaW50IG5jc2lfY21kX2hhbmRsZXJfc25mYyhzdHJ1Y3Qgc2tfYnVmZiAqc2tiLA0KICAgICAJ cmV0dXJuIDA7DQogICAgIH0NCiAgICAgDQogICAgK3N0YXRpYyBpbnQgbmNzaV9jbWRfaGFuZGxl cl9vZW0oc3RydWN0IHNrX2J1ZmYgKnNrYiwNCiAgICArCQkJCXN0cnVjdCBuY3NpX2NtZF9hcmcg Km5jYSkNCiAgICArew0KICAgICsJc3RydWN0IG5jc2lfY21kX29lbV9wa3QgKmNtZDsNCiAgICAr CXVuc2lnbmVkIGludCBsZW47DQogICAgKw0KICAgICsJbGVuID0gc2l6ZW9mKHN0cnVjdCBuY3Np X2NtZF9wa3RfaGRyKSArIDQ7DQogICAgKwlpZiAobmNhLT5wYXlsb2FkIDwgMjYpDQogICAgKwkJ bGVuICs9IDI2Ow0KICAgICsJZWxzZQ0KICAgICsJCWxlbiArPSBuY2EtPnBheWxvYWQ7DQogICAg Kw0KICAgICsJY21kID0gc2tiX3B1dF96ZXJvKHNrYiwgbGVuKTsNCiAgICArCWNtZC0+bWZyX2lk ID0gbmNhLT5kd29yZHNbMF07DQogICAgKwltZW1jcHkoY21kLT5kYXRhLCAmbmNhLT5kd29yZHNb MV0sIG5jYS0+cGF5bG9hZCAtIDQpOw0KICAgICsJbmNzaV9jbWRfYnVpbGRfaGVhZGVyKCZjbWQt PmNtZC5jb21tb24sIG5jYSk7DQogICAgKw0KICAgICsJcmV0dXJuIDA7DQogICAgK30NCiAgICAr DQogICAgIHN0YXRpYyBzdHJ1Y3QgbmNzaV9jbWRfaGFuZGxlciB7DQogICAgIAl1bnNpZ25lZCBj aGFyIHR5cGU7DQogICAgIAlpbnQgICAgICAgICAgIHBheWxvYWQ7DQogICAgQEAgLTI0NCw3ICsy NjQsNyBAQCBzdGF0aWMgc3RydWN0IG5jc2lfY21kX2hhbmRsZXIgew0KICAgICAJeyBOQ1NJX1BL VF9DTURfR05TLCAgICAwLCBuY3NpX2NtZF9oYW5kbGVyX2RlZmF1bHQgfSwNCiAgICAgCXsgTkNT SV9QS1RfQ01EX0dOUFRTLCAgMCwgbmNzaV9jbWRfaGFuZGxlcl9kZWZhdWx0IH0sDQogICAgIAl7 IE5DU0lfUEtUX0NNRF9HUFMsICAgIDAsIG5jc2lfY21kX2hhbmRsZXJfZGVmYXVsdCB9LA0KICAg IC0JeyBOQ1NJX1BLVF9DTURfT0VNLCAgICAwLCBOVUxMICAgICAgICAgICAgICAgICAgICAgfSwN CiAgICArCXsgTkNTSV9QS1RfQ01EX09FTSwgICAtMSwgbmNzaV9jbWRfaGFuZGxlcl9vZW0gICAg IH0sDQogICAgIAl7IE5DU0lfUEtUX0NNRF9QTERNLCAgIDAsIE5VTEwgICAgICAgICAgICAgICAg ICAgICB9LA0KICAgICAJeyBOQ1NJX1BLVF9DTURfR1BVVUlELCAwLCBuY3NpX2NtZF9oYW5kbGVy X2RlZmF1bHQgfQ0KICAgICB9Ow0KICAgIEBAIC0zMTYsOCArMzM2LDEzIEBAIGludCBuY3NpX3ht aXRfY21kKHN0cnVjdCBuY3NpX2NtZF9hcmcgKm5jYSkNCiAgICAgCQlyZXR1cm4gLUVOT0VOVDsN CiAgICAgCX0NCiAgICAgDQogICAgLQkvKiBHZXQgcGFja2V0IHBheWxvYWQgbGVuZ3RoIGFuZCBh bGxvY2F0ZSB0aGUgcmVxdWVzdCAqLw0KICAgIC0JbmNhLT5wYXlsb2FkID0gbmNoLT5wYXlsb2Fk Ow0KICAgICsJLyogR2V0IHBhY2tldCBwYXlsb2FkIGxlbmd0aCBhbmQgYWxsb2NhdGUgdGhlIHJl cXVlc3QNCiAgICArCSAqIEl0IGlzIGV4cGVjdGVkIHRoYXQgaWYgbGVuZ3RoIHNldCBhcyBuZWdh dGl2ZSBpbg0KICAgICsJICogaGFuZGxlciBzdHJ1Y3R1cmUgbWVhbnMgY2FsbGVyIGlzIGluaXRp YWxpemluZyBpdA0KICAgICsJICogYW5kIHNldHRpbmcgbGVuZ3RoIGluIG5jYSBiZWZvcmUgY2Fs bGluZyB4bWl0IGZ1bmN0aW9uDQogICAgKwkgKi8NCiAgICArCWlmIChuY2gtPnBheWxvYWQgPj0g MCkNCiAgICArCQluY2EtPnBheWxvYWQgPSBuY2gtPnBheWxvYWQ7DQogICAgIAluciA9IG5jc2lf YWxsb2NfY29tbWFuZChuY2EpOw0KICAgICAJaWYgKCFucikNCiAgICAgCQlyZXR1cm4gLUVOT01F TTsNCiAgICBkaWZmIC0tZ2l0IGEvbmV0L25jc2kvbmNzaS1wa3QuaCBiL25ldC9uY3NpL25jc2kt cGt0LmgNCiAgICBpbmRleCA5MWI0YjY2NDM4ZGYuLjFmMzM4Mzg2ODEwZCAxMDA2NDQNCiAgICAt LS0gYS9uZXQvbmNzaS9uY3NpLXBrdC5oDQogICAgKysrIGIvbmV0L25jc2kvbmNzaS1wa3QuaA0K ICAgIEBAIC0xNTEsNiArMTUxLDIyIEBAIHN0cnVjdCBuY3NpX2NtZF9zbmZjX3BrdCB7DQogICAg IAl1bnNpZ25lZCBjaGFyICAgICAgICAgICBwYWRbMjJdOw0KICAgICB9Ow0KICAgICANCiAgICAr LyogT0VNIFJlcXVlc3QgQ29tbWFuZCBhcyBwZXIgTkNTSSBTcGVjaWZpY2F0aW9uICovDQogICAg K3N0cnVjdCBuY3NpX2NtZF9vZW1fcGt0IHsNCiAgICArCXN0cnVjdCBuY3NpX2NtZF9wa3RfaGRy IGNtZDsgICAgICAgICAvKiBDb21tYW5kIGhlYWRlciAgICAqLw0KICAgICsJX19iZTMyICAgICAg ICAgICAgICAgICAgbWZyX2lkOyAgICAgIC8qIE1hbnVmYWN0dXJlIElEICAgICovDQogICAgKwl1 bnNpZ25lZCBjaGFyICAgICAgICAgICBkYXRhWzY0XTsgICAgLyogT0VNIFBheWxvYWQgRGF0YSAg Ki8NCiAgICArCV9fYmUzMiAgICAgICAgICAgICAgICAgIGNoZWNrc3VtOyAgICAvKiBDaGVja3N1 bSAgICAgICAgICAqLw0KICAgICt9Ow0KICAgICsNCiAgICArLyogT0VNIFJlc3BvbnNlIFBhY2tl dCBhcyBwZXIgTkNTSSBTcGVjaWZpY2F0aW9uICovDQogICAgK3N0cnVjdCBuY3NpX3JzcF9vZW1f cGt0IHsNCiAgICArCXN0cnVjdCBuY3NpX3JzcF9wa3RfaGRyIHJzcDsgICAgICAgICAvKiBDb21t YW5kIGhlYWRlciAgICAqLw0KICAgICsJX19iZTMyICAgICAgICAgICAgICAgICAgbWZyX2lkOyAg ICAgIC8qIE1hbnVmYWN0dXJlIElEICAgICovDQogICAgKwl1bnNpZ25lZCBjaGFyICAgICAgICAg ICBkYXRhWzY0XTsgICAgLyogUGF5bG9hZCBkYXRhICAgICAgKi8NCiAgICArCV9fYmUzMiAgICAg ICAgICAgICAgICAgIGNoZWNrc3VtOyAgICAvKiBDaGVja3N1bSAgICAgICAgICAqLw0KICAgICt9 Ow0KICAgICsNCiAgICAgLyogR2V0IExpbmsgU3RhdHVzICovDQogICAgIHN0cnVjdCBuY3NpX3Jz cF9nbHNfcGt0IHsNCiAgICAgCXN0cnVjdCBuY3NpX3JzcF9wa3RfaGRyIHJzcDsgICAgICAgIC8q IFJlc3BvbnNlIGhlYWRlciAgICovDQogICAgZGlmZiAtLWdpdCBhL25ldC9uY3NpL25jc2ktcnNw LmMgYi9uZXQvbmNzaS9uY3NpLXJzcC5jDQogICAgaW5kZXggOTMwYzFkMzc5NmYwLi4yMjY2NGVi ZGM5M2EgMTAwNjQ0DQogICAgLS0tIGEvbmV0L25jc2kvbmNzaS1yc3AuYw0KICAgICsrKyBiL25l dC9uY3NpL25jc2ktcnNwLmMNCiAgICBAQCAtNTk2LDYgKzU5Niw0OCBAQCBzdGF0aWMgaW50IG5j c2lfcnNwX2hhbmRsZXJfc25mYyhzdHJ1Y3QgbmNzaV9yZXF1ZXN0ICpucikNCiAgICAgCXJldHVy biAwOw0KICAgICB9DQogICAgIA0KICAgICtzdGF0aWMgc3RydWN0IG5jc2lfcnNwX29lbV9oYW5k bGVyIHsNCiAgICArCXVuc2lnbmVkIGludAltZnJfaWQ7DQogICAgKwlpbnQJCSgqaGFuZGxlciko c3RydWN0IG5jc2lfcmVxdWVzdCAqbnIpOw0KICAgICt9IG5jc2lfcnNwX29lbV9oYW5kbGVyc1td ID0gew0KICAgICsJeyBOQ1NJX09FTV9NRlJfTUxYX0lELCBOVUxMIH0sDQogICAgKwl7IE5DU0lf T0VNX01GUl9CQ01fSUQsIE5VTEwgfQ0KICAgICt9Ow0KICAgICsNCiAgICArDQogICAgKy8qIFJl c3BvbnNlIGhhbmRsZXIgZm9yIE9FTSBjb21tYW5kICovDQogICAgK3N0YXRpYyBpbnQgbmNzaV9y c3BfaGFuZGxlcl9vZW0oc3RydWN0IG5jc2lfcmVxdWVzdCAqbnIpDQogICAgK3sNCiAgICArCXN0 cnVjdCBuY3NpX3JzcF9vZW1fcGt0ICpyc3A7DQogICAgKwlzdHJ1Y3QgbmNzaV9yc3Bfb2VtX2hh bmRsZXIgKm5yaCA9IE5VTEw7DQogICAgKwl1bnNpZ25lZCBpbnQgbWZyX2lkLCBpOw0KICAgICsN CiAgICArCS8qIEdldCB0aGUgcmVzcG9uc2UgaGVhZGVyICovDQogICAgKwlyc3AgPSAoc3RydWN0 IG5jc2lfcnNwX29lbV9wa3QgKilza2JfbmV0d29ya19oZWFkZXIobnItPnJzcCk7DQogICAgKwlt ZnJfaWQgPSBudG9obChyc3AtPm1mcl9pZCk7DQogICAgKw0KICAgICsJLyogQ2hlY2sgZm9yIG1h bnVmYWN0dXJlciBpZCBhbmQgRmluZCB0aGUgaGFuZGxlciAqLw0KICAgICsJZm9yIChpID0gMDsg aSA8IEFSUkFZX1NJWkUobmNzaV9yc3Bfb2VtX2hhbmRsZXJzKTsgaSsrKSB7DQogICAgKwkJaWYg KG5jc2lfcnNwX29lbV9oYW5kbGVyc1tpXS5tZnJfaWQgPT0gbWZyX2lkKSB7DQogICAgKwkJCWlm IChuY3NpX3JzcF9vZW1faGFuZGxlcnNbaV0uaGFuZGxlcikNCiAgICArCQkJCW5yaCA9ICZuY3Np X3JzcF9vZW1faGFuZGxlcnNbaV07DQogICAgKwkJCWVsc2UNCiAgICArCQkJCW5yaCA9IE5VTEw7 DQogICAgKw0KICAgICsJCQlicmVhazsNCiAgICArCQl9DQogICAgKwl9DQogICAgKw0KICAgICsJ aWYgKCFucmgpIHsNCiAgICArCQluZXRkZXZfZXJyKG5yLT5uZHAtPm5kZXYuZGV2LCAiUmVjZWl2 ZWQgdW5yZWNvZ25pemVkIE9FTSBwYWNrZXQgd2l0aCBNRlItSUQgKDB4JXgpXG4iLA0KICAgICsJ CQkgICBtZnJfaWQpOw0KICAgICsJCXJldHVybiAtRU5PRU5UOw0KICAgICsJfQ0KICAgICsNCiAg ICArCS8qIFByb2Nlc3MgdGhlIHBhY2tldCAqLw0KICAgICsJcmV0dXJuIG5yaC0+aGFuZGxlcihu cik7DQogICAgK30NCiAgICArDQogICAgIHN0YXRpYyBpbnQgbmNzaV9yc3BfaGFuZGxlcl9ndmko c3RydWN0IG5jc2lfcmVxdWVzdCAqbnIpDQogICAgIHsNCiAgICAgCXN0cnVjdCBuY3NpX3JzcF9n dmlfcGt0ICpyc3A7DQogICAgQEAgLTkzMiw3ICs5NzQsNyBAQCBzdGF0aWMgc3RydWN0IG5jc2lf cnNwX2hhbmRsZXIgew0KICAgICAJeyBOQ1NJX1BLVF9SU1BfR05TLCAgIDE3MiwgbmNzaV9yc3Bf aGFuZGxlcl9nbnMgICAgIH0sDQogICAgIAl7IE5DU0lfUEtUX1JTUF9HTlBUUywgMTcyLCBuY3Np X3JzcF9oYW5kbGVyX2ducHRzICAgfSwNCiAgICAgCXsgTkNTSV9QS1RfUlNQX0dQUywgICAgIDgs IG5jc2lfcnNwX2hhbmRsZXJfZ3BzICAgICB9LA0KICAgIC0JeyBOQ1NJX1BLVF9SU1BfT0VNLCAg ICAgMCwgTlVMTCAgICAgICAgICAgICAgICAgICAgIH0sDQogICAgKwl7IE5DU0lfUEtUX1JTUF9P RU0sICAgIC0xLCBuY3NpX3JzcF9oYW5kbGVyX29lbSAgICAgfSwNCiAgICAgCXsgTkNTSV9QS1Rf UlNQX1BMRE0sICAgIDAsIE5VTEwgICAgICAgICAgICAgICAgICAgICB9LA0KICAgICAJeyBOQ1NJ X1BLVF9SU1BfR1BVVUlELCAyMCwgbmNzaV9yc3BfaGFuZGxlcl9ncHV1aWQgIH0NCiAgICAgfTsN CiAgICAtLSANCiAgICAyLjE3LjENCiAgICANCiAgICANCg0K