From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lawrence Brakmo Subject: Re: [PATCH net-next] bpf: Add access to snd_cwnd and others in sock_ops Date: Tue, 5 Dec 2017 00:21:01 +0000 Message-ID: References: <20171201181504.1040223-1-brakmo@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Alexei Starovoitov , Kernel Team , "Blake Matheny" , Vlad Dumitrescu To: Daniel Borkmann , netdev Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:54146 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751200AbdLEAVd (ORCPT ); Mon, 4 Dec 2017 19:21:33 -0500 In-Reply-To: Content-Language: en-US Content-ID: <96716003915462438E402106404C5BDC@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gMTIvNC8xNywgMjozMiBQTSwgIm5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmcgb24gYmVo YWxmIG9mIERhbmllbCBCb3JrbWFubiIgPG5ldGRldi1vd25lckB2Z2VyLmtlcm5lbC5vcmcgb24g YmVoYWxmIG9mIGRhbmllbEBpb2dlYXJib3gubmV0PiB3cm90ZToNCg0KICAgIEhpIExhd3JlbmNl LA0KICAgIA0KICAgIE9uIDEyLzAxLzIwMTcgMDc6MTUgUE0sIExhd3JlbmNlIEJyYWttbyB3cm90 ZToNCiAgICA+IEFkZHMgcmVhZCBhY2Nlc3MgdG8gc25kX2N3bmQgYW5kIHNydHRfdXMgZmllbGRz IG9mIHRjcF9zb2NrLiBTaW5jZSB0aGVzZQ0KICAgID4gZmllbGRzIGFyZSBvbmx5IHZhbGlkIGlm IHRoZSBzb2NrZXQgYXNzb2NpYXRlZCB3aXRoIHRoZSBzb2NrX29wcyBwcm9ncmFtDQogICAgPiBj YWxsIGlzIGEgZnVsbCBzb2NrZXQsIHRoZSBmaWVsZCBpc19mdWxsc29jayBpcyBhbHNvIGFkZGVk IHRvIHRoZQ0KICAgID4gYnBmX3NvY2tfb3BzIHN0cnVjdC4gSWYgdGhlIHNvY2tldCBpcyBub3Qg YSBmdWxsIHNvY2tldCwgcmVhZGluZyB0aGVzZQ0KICAgID4gZmllbGRzIHJldHVybnMgMC4NCiAg ICA+IA0KICAgID4gTm90ZSB0aGF0IGluIG1vc3QgY2FzZXMgaXQgd2lsbCBub3QgYmUgbmVjZXNz YXJ5IHRvIGNoZWNrIGlzX2Z1bGxzb2NrIHRvDQogICAgPiBrbm93IGlmIHRoZXJlIGlzIGEgZnVs bCBzb2NrZXQuIFRoZSBjb250ZXh0IG9mIHRoZSBjYWxsLCBhcyBzcGVjaWZpZWQgYnkNCiAgICA+ IHRoZSAnb3AnIGZpZWxkLCBjYW4gc29tZXRpbWVzIGRldGVybWluZSB3aGV0aGVyIHRoZXJlIGlz IGEgZnVsbCBzb2NrZXQuDQogICAgPiANCiAgICA+IFRoZSBzdHJ1Y3QgYnBmX3NvY2tfb3BzIGhh cyB0aGUgZm9sbG93aW5nIGZpZWxkcyBhZGRlZDoNCiAgICA+IA0KICAgID4gICBfX3UzMiBpc19m dWxsc29jazsgICAgICAvKiBTb21lIFRDUCBmaWVsZHMgYXJlIG9ubHkgdmFsaWQgaWYNCiAgICA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICogdGhlcmUgaXMgYSBmdWxsIHNvY2tldC4gSWYg bm90LCB0aGUNCiAgICA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICogZmllbGRzIHJlYWQg YXMgemVyby4NCiAgICA+IAkJCSAgICovDQogICAgPiAgIF9fdTMyIHNuZF9jd25kOw0KICAgID4g ICBfX3UzMiBzcnR0X3VzOyAgICAgICAgICAvKiBBdmVyYWdlZCBSVFQgPDwgMyBpbiB1c2VjcyAq Lw0KICAgID4gDQogICAgPiBUaGVyZSBpcyBhIG5ldyBtYWNybywgU09DS19PUFNfR0VUX1RDUDMy KE5BTUUpLCB0byBtYWtlIGl0IGVhc2llciB0byBhZGQNCiAgICA+IHJlYWQgYWNjZXNzIHRvIG1v cmUgMzIgYml0IHRjcF9zb2NrIGZpZWxkcy4NCiAgICA+IA0KICAgID4gU2lnbmVkLW9mZi1ieTog TGF3cmVuY2UgQnJha21vIDxicmFrbW9AZmIuY29tPg0KICAgID4gLS0tDQogICAgPiAgaW5jbHVk ZS9saW51eC9maWx0ZXIuaCAgIHwgIDEgKw0KICAgID4gIGluY2x1ZGUvbmV0L3RjcC5oICAgICAg ICB8ICA2ICsrKystLQ0KICAgID4gIGluY2x1ZGUvdWFwaS9saW51eC9icGYuaCB8ICA2ICsrKysr Kw0KICAgID4gIG5ldC9jb3JlL2ZpbHRlci5jICAgICAgICB8IDM2ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKw0KICAgID4gIDQgZmlsZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkNCiAgICA+IA0KICAgID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv bGludXgvZmlsdGVyLmggYi9pbmNsdWRlL2xpbnV4L2ZpbHRlci5oDQogICAgPiBpbmRleCA4MGI1 YjQ4Li4wMDYyMzAyIDEwMDY0NA0KICAgID4gLS0tIGEvaW5jbHVkZS9saW51eC9maWx0ZXIuaA0K ICAgID4gKysrIGIvaW5jbHVkZS9saW51eC9maWx0ZXIuaA0KICAgID4gQEAgLTk4NSw2ICs5ODUs NyBAQCBzdHJ1Y3QgYnBmX3NvY2tfb3BzX2tlcm4gew0KICAgID4gIAkJdTMyIHJlcGx5Ow0KICAg ID4gIAkJdTMyIHJlcGx5bG9uZ1s0XTsNCiAgICA+ICAJfTsNCiAgICA+ICsJdTMyCWlzX2Z1bGxz b2NrOw0KICAgID4gIH07DQogICAgPiAgDQogICAgPiAgI2VuZGlmIC8qIF9fTElOVVhfRklMVEVS X0hfXyAqLw0KICAgID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbmV0L3RjcC5oIGIvaW5jbHVkZS9u ZXQvdGNwLmgNCiAgICA+IGluZGV4IDRlMDkzOTguLjg5YTY1NjAgMTAwNjQ0DQogICAgPiAtLS0g YS9pbmNsdWRlL25ldC90Y3AuaA0KICAgID4gKysrIGIvaW5jbHVkZS9uZXQvdGNwLmgNCiAgICA+ IEBAIC0yMDEyLDEwICsyMDEyLDEyIEBAIHN0YXRpYyBpbmxpbmUgaW50IHRjcF9jYWxsX2JwZihz dHJ1Y3Qgc29jayAqc2ssIGludCBvcCkNCiAgICA+ICAJc3RydWN0IGJwZl9zb2NrX29wc19rZXJu IHNvY2tfb3BzOw0KICAgID4gIAlpbnQgcmV0Ow0KICAgID4gIA0KICAgID4gLQlpZiAoc2tfZnVs bHNvY2soc2spKQ0KICAgID4gKwltZW1zZXQoJnNvY2tfb3BzLCAwLCBzaXplb2Yoc29ja19vcHMp KTsNCiAgICA+ICsJaWYgKHNrX2Z1bGxzb2NrKHNrKSkgew0KICAgID4gKwkJc29ja19vcHMuaXNf ZnVsbHNvY2sgPSAxOw0KICAgID4gIAkJc29ja19vd25lZF9ieV9tZShzayk7DQogICAgPiArCX0N CiAgICA+ICANCiAgICA+IC0JbWVtc2V0KCZzb2NrX29wcywgMCwgc2l6ZW9mKHNvY2tfb3BzKSk7 DQogICAgPiAgCXNvY2tfb3BzLnNrID0gc2s7DQogICAgPiAgCXNvY2tfb3BzLm9wID0gb3A7DQog ICAgPiAgDQogICAgPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2xpbnV4L2JwZi5oIGIvaW5j bHVkZS91YXBpL2xpbnV4L2JwZi5oDQogICAgPiBpbmRleCA0YzIyM2FiLi44MGQ2MmU4IDEwMDY0 NA0KICAgID4gLS0tIGEvaW5jbHVkZS91YXBpL2xpbnV4L2JwZi5oDQogICAgPiArKysgYi9pbmNs dWRlL3VhcGkvbGludXgvYnBmLmgNCiAgICA+IEBAIC05NDEsNiArOTQxLDEyIEBAIHN0cnVjdCBi cGZfc29ja19vcHMgew0KICAgID4gIAlfX3UzMiBsb2NhbF9pcDZbNF07CS8qIFN0b3JlZCBpbiBu ZXR3b3JrIGJ5dGUgb3JkZXIgKi8NCiAgICA+ICAJX191MzIgcmVtb3RlX3BvcnQ7CS8qIFN0b3Jl ZCBpbiBuZXR3b3JrIGJ5dGUgb3JkZXIgKi8NCiAgICA+ICAJX191MzIgbG9jYWxfcG9ydDsJLyog c3RvcmVkIGluIGhvc3QgYnl0ZSBvcmRlciAqLw0KICAgID4gKwlfX3UzMiBpc19mdWxsc29jazsJ LyogU29tZSBUQ1AgZmllbGRzIGFyZSBvbmx5IHZhbGlkIGlmDQogICAgPiArCQkJCSAqIHRoZXJl IGlzIGEgZnVsbCBzb2NrZXQuIElmIG5vdCwgdGhlDQogICAgPiArCQkJCSAqIGZpZWxkcyByZWFk IGFzIHplcm8uDQogICAgPiArCQkJCSAqLw0KICAgIA0KICAgIEp1c3QgYSBxdWVzdGlvbiBmb3Ig Y2xhcmlmaWNhdGlvbjogZG8geW91IG5lZWQgdG8gaGF2ZSB0aGlzIGluDQogICAgdGhlIHVhcGkg c3RydWN0IGFzIHdlbGw/IE1lYW5pbmcsIGRvIHlvdSBoYXZlIGEgc3BlY2lmaWMgdXNlIGNhc2UN CiAgICB3aGVyZSB5b3UgZG8gdGhpcyBjaGVjayBvdXQgb2YgdGhlIEJQRiBwcm9ncmFtIGdpdmVu IHRoZSBiZWxvdw0KICAgIHR3byBzbmRfY3duZC9zcnR0X3VzIGNoZWNrIHRoaXMgaW50ZXJuYWxs eSBpbiB0aGUgY3R4IHJld3JpdGU/DQogICAgDQpBbHRob3VnaCBpc19mdWxsc29jayBpcyBjaGVj a2VkIGludGVybmFsbHksIHRoZSBicGYgcHJvZ3JhbSBtYXkgd2FudCB0bw0KdmVyaWZ5IGlmIGEg cmV0dXJuIHZhbHVlIG9mIHplcm8gaXMgZHVlIHRvIGEgbm9uIGZ1bGxzb2NrIHN0YXRlLiBUaGUg aXNzdWUgaXMNCnRoYXQgdGhlcmUgYXJlIHNvbWUgb3BzIHRoYXQgYXJlIGNhbGxlZCBmcm9tIGJv dGggYWN0aXZlIGFuZCBwYXNzaXZlIHBhdGhzDQpzbyBpdCBpcyBub3QgcG9zc2libGUgdG8ga25v dyBqdXN0IGJ5IHRoZSBvcCB0eXBlLg0KDQogICAgRG8geW91IHBsYW4gdG8gcmV1c2UgdGhlIGN0 eCBhc3NpZ25tZW50IGFsc28gZm9yIGJwZl9zZXRzb2Nrb3B0KCkNCiAgICBhbmQgYnBmX2dldHNv Y2tvcHQoKSBpbnRlcm5hbGx5Pw0KDQpJZiB5b3UgbWVhbiwgY2hlY2sgaXNfZnVsbHNvY2sgaW5z dGVhZCBvZiB0aGUgY2FsbCB0byBza19mdWxsc29jaywgdGhlbiB5ZXMsIGl0IGlzDQphIGdyZWF0 IGlkZWEuIEhvd2V2ZXIsIEkgd291bGQgcmF0aGVyIGRvIGl0IGluIGFub3RoZXIgcGF0Y2ggc28g d2UgZG9u4oCZdCBkZWxheQ0KdGhpcyBvbmUgKEkgaGF2ZSBvdGhlciB0aGluZ3MgYWxtb3N0IHJl YWR5IHRoYXQgZGVwZW5kIG9uIHRoaXMgcGF0Y2gpLg0KDQogICAgPiArCV9fdTMyIHNuZF9jd25k Ow0KICAgID4gKwlfX3UzMiBzcnR0X3VzOwkJLyogQXZlcmFnZWQgUlRUIDw8IDMgaW4gdXNlY3Mg Ki8NCiAgICA+ICB9Ow0KICAgID4gIA0KICAgID4gIC8qIExpc3Qgb2Yga25vd24gQlBGIHNvY2tf b3BzIG9wZXJhdG9ycy4NCiAgICA+IGRpZmYgLS1naXQgYS9uZXQvY29yZS9maWx0ZXIuYyBiL25l dC9jb3JlL2ZpbHRlci5jDQogICAgPiBpbmRleCA2YTg1ZTY3Li5iZjMxMjM2IDEwMDY0NA0KICAg ID4gLS0tIGEvbmV0L2NvcmUvZmlsdGVyLmMNCiAgICA+ICsrKyBiL25ldC9jb3JlL2ZpbHRlci5j DQogICAgPiBAQCAtNDQzNyw2ICs0NDM3LDQyIEBAIHN0YXRpYyB1MzIgc29ja19vcHNfY29udmVy dF9jdHhfYWNjZXNzKGVudW0gYnBmX2FjY2Vzc190eXBlIHR5cGUsDQogICAgPiAgCQkqaW5zbisr ID0gQlBGX0xEWF9NRU0oQlBGX0gsIHNpLT5kc3RfcmVnLCBzaS0+ZHN0X3JlZywNCiAgICA+ICAJ CQkJICAgICAgb2Zmc2V0b2Yoc3RydWN0IHNvY2tfY29tbW9uLCBza2NfbnVtKSk7DQogICAgPiAg CQlicmVhazsNCiAgICA+ICsNCiAgICA+ICsJY2FzZSBvZmZzZXRvZihzdHJ1Y3QgYnBmX3NvY2tf b3BzLCBpc19mdWxsc29jayk6DQogICAgPiArCQkqaW5zbisrID0gQlBGX0xEWF9NRU0oQlBGX0ZJ RUxEX1NJWkVPRigNCiAgICA+ICsJCQkJCQlzdHJ1Y3QgYnBmX3NvY2tfb3BzX2tlcm4sDQogICAg PiArCQkJCQkJaXNfZnVsbHNvY2spLA0KICAgID4gKwkJCQkgICAgICBzaS0+ZHN0X3JlZywgc2kt PnNyY19yZWcsDQogICAgPiArCQkJCSAgICAgIG9mZnNldG9mKHN0cnVjdCBicGZfc29ja19vcHNf a2VybiwNCiAgICA+ICsJCQkJCSAgICAgICBpc19mdWxsc29jaykpOw0KICAgID4gKwkJYnJlYWs7 DQogICAgPiArDQogICAgPiArLyogSGVscGVyIG1hY3JvIGZvciBhZGRpbmcgcmVhZCBhY2Nlc3Mg dG8gdGNwX3NvY2sgZmllbGRzLiAqLw0KICAgID4gKyNkZWZpbmUgU09DS19PUFNfR0VUX1RDUDMy KEZJRUxEX05BTUUpCQkJCQkgICAgICBcDQogICAgPiArCWRvIHsJCQkJCQkJCSAgICAgIFwNCiAg ICA+ICsJCUJVSUxEX0JVR19PTihGSUVMRF9TSVpFT0Yoc3RydWN0IHRjcF9zb2NrLCBGSUVMRF9O QU1FKSAhPSA0KTsgXA0KICAgID4gKwkJKmluc24rKyA9IEJQRl9MRFhfTUVNKEJQRl9GSUVMRF9T SVpFT0YoCQkJICAgICAgXA0KICAgID4gKwkJCQkJCXN0cnVjdCBicGZfc29ja19vcHNfa2Vybiwg ICAgIFwNCiAgICA+ICsJCQkJCQlpc19mdWxsc29jayksCQkgICAgICBcDQogICAgPiArCQkJCSAg ICAgIHNpLT5kc3RfcmVnLCBzaS0+c3JjX3JlZywJCSAgICAgIFwNCiAgICA+ICsJCQkJICAgICAg b2Zmc2V0b2Yoc3RydWN0IGJwZl9zb2NrX29wc19rZXJuLCAgICAgIFwNCiAgICA+ICsJCQkJCSAg ICAgICBpc19mdWxsc29jaykpOwkJICAgICAgXA0KICAgID4gKwkJKmluc24rKyA9IEJQRl9KTVBf SU1NKEJQRl9KRVEsIHNpLT5kc3RfcmVnLCAwLCAyKTsJICAgICAgXA0KICAgID4gKwkJKmluc24r KyA9IEJQRl9MRFhfTUVNKEJQRl9GSUVMRF9TSVpFT0YoCQkJICAgICAgXA0KICAgID4gKwkJCQkJ CXN0cnVjdCBicGZfc29ja19vcHNfa2Vybiwgc2spLFwNCiAgICA+ICsJCQkJICAgICAgc2ktPmRz dF9yZWcsIHNpLT5zcmNfcmVnLAkJICAgICAgXA0KICAgID4gKwkJCQkgICAgICBvZmZzZXRvZihz dHJ1Y3QgYnBmX3NvY2tfb3BzX2tlcm4sIHNrKSk7XA0KICAgID4gKwkJKmluc24rKyA9IEJQRl9M RFhfTUVNKEJQRl9XLCBzaS0+ZHN0X3JlZywgc2ktPmRzdF9yZWcsICAgICAgICBcDQogICAgPiAr CQkJCSAgICAgIG9mZnNldG9mKHN0cnVjdCB0Y3Bfc29jaywgRklFTERfTkFNRSkpOyBcDQogICAg PiArCX0gd2hpbGUgKDApDQogICAgPiArDQogICAgPiArCWNhc2Ugb2Zmc2V0b2Yoc3RydWN0IGJw Zl9zb2NrX29wcywgc25kX2N3bmQpOg0KICAgID4gKwkJU09DS19PUFNfR0VUX1RDUDMyKHNuZF9j d25kKTsNCiAgICA+ICsJCWJyZWFrOw0KICAgID4gKw0KICAgID4gKwljYXNlIG9mZnNldG9mKHN0 cnVjdCBicGZfc29ja19vcHMsIHNydHRfdXMpOg0KICAgID4gKwkJU09DS19PUFNfR0VUX1RDUDMy KHNydHRfdXMpOw0KICAgID4gKwkJYnJlYWs7DQogICAgPiAgCX0NCiAgICA+ICAJcmV0dXJuIGlu c24gLSBpbnNuX2J1ZjsNCiAgICA+ICB9DQogICAgPiANCiAgICANCiAgICANCg0K