From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lawrence Brakmo Subject: Re: [PATCH bpf-next v6 07/11] bpf: Add support for reading sk_state and more Date: Wed, 24 Jan 2018 01:27:09 +0000 Message-ID: References: <20180120014548.2941040-1-brakmo@fb.com> <20180120014548.2941040-8-brakmo@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Kernel Team , Blake Matheny , "Alexei Starovoitov" , Eric Dumazet , "Neal Cardwell" , Yuchung Cheng To: Daniel Borkmann , netdev Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40152 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbeAXB1d (ORCPT ); Tue, 23 Jan 2018 20:27:33 -0500 In-Reply-To: Content-Language: en-US Content-ID: <460BC521FEE9644996276AFE3B4E95B0@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gMS8yMy8xOCwgNTowNSBQTSwgIkRhbmllbCBCb3JrbWFubiIgPGRhbmllbEBpb2dlYXJib3gu bmV0PiB3cm90ZToNCg0KICAgIE9uIDAxLzIwLzIwMTggMDI6NDUgQU0sIExhd3JlbmNlIEJyYWtt byB3cm90ZToNCiAgICA+IEFkZCBzdXBwb3J0IGZvciByZWFkaW5nIG1hbnkgbW9yZSB0Y3Bfc29j ayBmaWVsZHMNCiAgICA+IA0KICAgID4gICBzdGF0ZSwJc2FtZSBhcyBzay0+c2tfc3RhdGUNCiAg ICA+ICAgcnR0X21pbglzYW1lIGFzIHNrLT5ydHRfbWluLnNbMF0udiAoY3VycmVudCBydHRfbWlu KQ0KICAgID4gICBzbmRfc3N0aHJlc2gNCiAgICA+ICAgcmN2X254dA0KICAgID4gICBzbmRfbnh0 DQogICAgPiAgIHNuZF91bmENCiAgICA+ICAgbXNzX2NhY2hlDQogICAgPiAgIGVjbl9mbGFncw0K ICAgID4gICByYXRlX2RlbGl2ZXJlZA0KICAgID4gICByYXRlX2ludGVydmFsX3VzDQogICAgPiAg IHBhY2tldHNfb3V0DQogICAgPiAgIHJldHJhbnNfb3V0DQogICAgPiAgIHRvdGFsX3JldHJhbnMN CiAgICA+ICAgc2Vnc19pbg0KICAgID4gICBkYXRhX3NlZ3NfaW4NCiAgICA+ICAgc2Vnc19vdXQN CiAgICA+ICAgZGF0YV9zZWdzX291dA0KICAgID4gICBieXRlc19yZWNlaXZlZCAoX191NjQpDQog ICAgPiAgIGJ5dGVzX2Fja2VkICAgIChfX3U2NCkNCiAgICA+IA0KICAgID4gU2lnbmVkLW9mZi1i eTogTGF3cmVuY2UgQnJha21vIDxicmFrbW9AZmIuY29tPg0KICAgID4gLS0tDQogICAgPiAgaW5j bHVkZS91YXBpL2xpbnV4L2JwZi5oIHwgIDE5ICsrKysrKysNCiAgICA+ICBuZXQvY29yZS9maWx0 ZXIuYyAgICAgICAgfCAxMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0NCiAgICA+ICAyIGZpbGVzIGNoYW5nZWQsIDE0MCBpbnNlcnRpb25zKCspLCAxMyBk ZWxldGlvbnMoLSkNCiAgICA+IA0KICAgID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvdWFwaS9saW51 eC9icGYuaCBiL2luY2x1ZGUvdWFwaS9saW51eC9icGYuaA0KICAgID4gaW5kZXggMmE4YzQwYS4u ZmYzNGYzYyAxMDA2NDQNCiAgICA+IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC9icGYuaA0KICAg ID4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L2JwZi5oDQogICAgPiBAQCAtOTc5LDYgKzk3OSwy NSBAQCBzdHJ1Y3QgYnBmX3NvY2tfb3BzIHsNCiAgICA+ICAJX191MzIgc25kX2N3bmQ7DQogICAg PiAgCV9fdTMyIHNydHRfdXM7CQkvKiBBdmVyYWdlZCBSVFQgPDwgMyBpbiB1c2VjcyAqLw0KICAg ID4gIAlfX3UzMiBicGZfc29ja19vcHNfY2JfZmxhZ3M7IC8qIGZsYWdzIGRlZmluZWQgaW4gdWFw aS9saW51eC90Y3AuaCAqLw0KICAgID4gKwlfX3UzMiBzdGF0ZTsNCiAgICA+ICsJX191MzIgcnR0 X21pbjsNCiAgICA+ICsJX191MzIgc25kX3NzdGhyZXNoOw0KICAgID4gKwlfX3UzMiByY3Zfbnh0 Ow0KICAgID4gKwlfX3UzMiBzbmRfbnh0Ow0KICAgID4gKwlfX3UzMiBzbmRfdW5hOw0KICAgID4g KwlfX3UzMiBtc3NfY2FjaGU7DQogICAgPiArCV9fdTMyIGVjbl9mbGFnczsNCiAgICA+ICsJX191 MzIgcmF0ZV9kZWxpdmVyZWQ7DQogICAgPiArCV9fdTMyIHJhdGVfaW50ZXJ2YWxfdXM7DQogICAg PiArCV9fdTMyIHBhY2tldHNfb3V0Ow0KICAgID4gKwlfX3UzMiByZXRyYW5zX291dDsNCiAgICA+ ICsJX191MzIgdG90YWxfcmV0cmFuczsNCiAgICA+ICsJX191MzIgc2Vnc19pbjsNCiAgICA+ICsJ X191MzIgZGF0YV9zZWdzX2luOw0KICAgID4gKwlfX3UzMiBzZWdzX291dDsNCiAgICA+ICsJX191 MzIgZGF0YV9zZWdzX291dDsNCiAgICANCiAgICBCdHcsIHRoaXMgd2lsbCBoYXZlIGEgNCBieXRl cyBob2xlIGluIGhlcmUgd2hpY2ggdGhlIHVzZXIgY2FuIG90aGVyd2lzZQ0KICAgIGFkZHJlc3Mg b3V0IG9mIHRoZSBwcm9nLiBDb3VsZCB5b3UgYWRkIHRoZSBza190eGhhc2ggZnJvbSB0aGUgbmV4 dCBwYXRjaA0KICAgIGluIGJldHdlZW4gaGVyZSBpbnN0ZWFkPw0KICAgIA0KR29vZCBwb2ludC4g V2lsbCBmaXggaW4gbmV3IHBhdGNoLiBUaGFua3MgRGFuaWVsLg0KDQogICAgPiArCV9fdTY0IGJ5 dGVzX3JlY2VpdmVkOw0KICAgID4gKwlfX3U2NCBieXRlc19hY2tlZDsNCiAgICA+ICB9Ow0KICAg ID4gIA0KICAgID4gIC8qIExpc3Qgb2Yga25vd24gQlBGIHNvY2tfb3BzIG9wZXJhdG9ycy4NCiAg ICA+IGRpZmYgLS1naXQgYS9uZXQvY29yZS9maWx0ZXIuYyBiL25ldC9jb3JlL2ZpbHRlci5jDQog ICAgPiBpbmRleCBjOTQxMWRjLi45ODY2NWJhIDEwMDY0NA0KICAgID4gLS0tIGEvbmV0L2NvcmUv ZmlsdGVyLmMNCiAgICA+ICsrKyBiL25ldC9jb3JlL2ZpbHRlci5jDQogICAgPiBAQCAtMzg0OSwz NCArMzg0OSw0MyBAQCB2b2lkIGJwZl93YXJuX2ludmFsaWRfeGRwX2FjdGlvbih1MzIgYWN0KQ0K ICAgID4gIH0NCiAgICA+ICBFWFBPUlRfU1lNQk9MX0dQTChicGZfd2Fybl9pbnZhbGlkX3hkcF9h Y3Rpb24pOw0KICAgID4gIA0KICAgID4gLXN0YXRpYyBib29sIF9faXNfdmFsaWRfc29ja19vcHNf YWNjZXNzKGludCBvZmYsIGludCBzaXplKQ0KICAgID4gK3N0YXRpYyBib29sIHNvY2tfb3BzX2lz X3ZhbGlkX2FjY2VzcyhpbnQgb2ZmLCBpbnQgc2l6ZSwNCiAgICA+ICsJCQkJICAgICBlbnVtIGJw Zl9hY2Nlc3NfdHlwZSB0eXBlLA0KICAgID4gKwkJCQkgICAgIHN0cnVjdCBicGZfaW5zbl9hY2Nl c3NfYXV4ICppbmZvKQ0KICAgID4gIHsNCiAgICA+ICsJY29uc3QgaW50IHNpemVfZGVmYXVsdCA9 IHNpemVvZihfX3UzMik7DQogICAgPiArDQogICAgPiAgCWlmIChvZmYgPCAwIHx8IG9mZiA+PSBz aXplb2Yoc3RydWN0IGJwZl9zb2NrX29wcykpDQogICAgPiAgCQlyZXR1cm4gZmFsc2U7DQogICAg PiArDQogICAgPiAgCS8qIFRoZSB2ZXJpZmllciBndWFyYW50ZWVzIHRoYXQgc2l6ZSA+IDAuICov DQogICAgPiAgCWlmIChvZmYgJSBzaXplICE9IDApDQogICAgPiAgCQlyZXR1cm4gZmFsc2U7DQog ICAgPiAtCWlmIChzaXplICE9IHNpemVvZihfX3UzMikpDQogICAgPiAtCQlyZXR1cm4gZmFsc2U7 DQogICAgPiAtDQogICAgPiAtCXJldHVybiB0cnVlOw0KICAgID4gLX0NCiAgICA+ICANCiAgICA+ IC1zdGF0aWMgYm9vbCBzb2NrX29wc19pc192YWxpZF9hY2Nlc3MoaW50IG9mZiwgaW50IHNpemUs DQogICAgPiAtCQkJCSAgICAgZW51bSBicGZfYWNjZXNzX3R5cGUgdHlwZSwNCiAgICA+IC0JCQkJ ICAgICBzdHJ1Y3QgYnBmX2luc25fYWNjZXNzX2F1eCAqaW5mbykNCiAgICA+IC17DQogICAgPiAg CWlmICh0eXBlID09IEJQRl9XUklURSkgew0KICAgID4gIAkJc3dpdGNoIChvZmYpIHsNCiAgICA+ IC0JCWNhc2Ugb2Zmc2V0b2Yoc3RydWN0IGJwZl9zb2NrX29wcywgb3ApIC4uLg0KICAgID4gLQkJ ICAgICBvZmZzZXRvZihzdHJ1Y3QgYnBmX3NvY2tfb3BzLCByZXBseWxvbmdbM10pOg0KICAgID4g KwkJY2FzZSBicGZfY3R4X3JhbmdlX3RpbGwoc3RydWN0IGJwZl9zb2NrX29wcywgb3AsIHJlcGx5 bG9uZ1szXSk6DQogICAgPiArCQkJaWYgKHNpemUgIT0gc2l6ZV9kZWZhdWx0KQ0KICAgID4gKwkJ CQlyZXR1cm4gZmFsc2U7DQogICAgPiAgCQkJYnJlYWs7DQogICAgPiAgCQlkZWZhdWx0Og0KICAg ID4gIAkJCXJldHVybiBmYWxzZTsNCiAgICA+ICAJCX0NCiAgICA+ICsJfSBlbHNlIHsNCiAgICA+ ICsJCXN3aXRjaCAob2ZmKSB7DQogICAgPiArCQljYXNlIGJwZl9jdHhfcmFuZ2VfdGlsbChzdHJ1 Y3QgYnBmX3NvY2tfb3BzLCBieXRlc19yZWNlaXZlZCwNCiAgICA+ICsJCQkJCWJ5dGVzX2Fja2Vk KToNCiAgICA+ICsJCQlpZiAoc2l6ZSAhPSBzaXplb2YoX191NjQpKQ0KICAgID4gKwkJCQlyZXR1 cm4gZmFsc2U7DQogICAgPiArCQkJYnJlYWs7DQogICAgPiArCQlkZWZhdWx0Og0KICAgID4gKwkJ CWlmIChzaXplICE9IHNpemVfZGVmYXVsdCkNCiAgICA+ICsJCQkJcmV0dXJuIGZhbHNlOw0KICAg ID4gKwkJCWJyZWFrOw0KICAgID4gKwkJfQ0KICAgID4gIAl9DQogICAgPiAgDQogICAgPiAtCXJl dHVybiBfX2lzX3ZhbGlkX3NvY2tfb3BzX2FjY2VzcyhvZmYsIHNpemUpOw0KICAgID4gKwlyZXR1 cm4gdHJ1ZTsNCiAgICA+ICB9DQogICAgDQoNCg==