From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7135DC31E58 for ; Mon, 17 Jun 2019 14:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4994C2084B for ; Mon, 17 Jun 2019 14:14:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="iLTj9CW1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbfFQOO2 (ORCPT ); Mon, 17 Jun 2019 10:14:28 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:41333 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfFQOO2 (ORCPT ); Mon, 17 Jun 2019 10:14:28 -0400 Received: by mail-io1-f66.google.com with SMTP id w25so21410388ioc.8 for ; Mon, 17 Jun 2019 07:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JohzNFDqmktDG38rF4I6wEqhVEhI+kZN53amqkDtO9w=; b=iLTj9CW1lG44z6zG4g72qDio7OVGQ1qANRuf1odp+rHFRdGUwpC/crqtmZviZTJjha UtbuW0PlSUt3tPiVOOOGTLydHXo9gGuO4n6AjAd9Ui2JaV31NFPjV2LvjHM7Lc94hAj3 2NoQNsPbAu20BCZqt728HIJTa2HSnRFbDzZ5I8vHPDybVf1pkrTRlkIQTt7rthVHXrAM lHS78Ey4P/EiXWCuhSzCFdoxrAgtO7jORwoA76aPcjYfK1cFsylabCMWL2k6C+IUbYR4 GFg6aCzi53pHsNhbAN3fRtSC15Up6LfUVSf/tWR82B4diNQ+xrqBZiH+dX91u+09QU+k cDxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JohzNFDqmktDG38rF4I6wEqhVEhI+kZN53amqkDtO9w=; b=OFKoYrCdeitDSvbnhDlflKQ5MOcOHYbuGdiK4cFAJRrTg8azeyVNN2f/ctGgJlLGm8 f3V6Lb7xG4ungr1W+Fr0eb5WBLmCu9VUjS83/9sm71uijeFpjAmeNz/x64nkh3cMF7fB ikrkJMCCwyTTB8YJpc1k538V48kuyY1Wh8wsKunJIIlezxq7wQkjgsQUBn8dUFAVFuwO D/YY+hec9FVIL55oimzJOKMujPoVJLVFhdL+QF+D7xbLy1ePxtBfvj3YhwoiM+NyQz6V R/2awDiW0u65UmF8PYRTfb5Lb6viobcGnfkj+cxFwbFVWpZiVdIkPz8mQqf6OdNVZ4tc AwvA== X-Gm-Message-State: APjAAAW6w1g1/DKTZcwGjsWTgt/wuWFFWcdWfBw0BVeoX54aLc1YF//X Z4H86izDUTxVZwD01k/N8ZOi1Q== X-Google-Smtp-Source: APXvYqzNuUBfwfuXW1mSryelHWlKsBM9fYoJ3JGS5e7VGKacU4dkepDULY1G4gM/fW95GIKtGZpt+Q== X-Received: by 2002:a6b:fb02:: with SMTP id h2mr14476535iog.289.1560780867625; Mon, 17 Jun 2019 07:14:27 -0700 (PDT) Received: from [192.168.1.196] ([216.160.37.230]) by smtp.gmail.com with ESMTPSA id c2sm8811901iok.53.2019.06.17.07.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 07:14:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000 From: Troy Benjegerdes In-Reply-To: Date: Mon, 17 Jun 2019 09:14:25 -0500 Cc: Andreas Schwab , Mark Rutland , devicetree@vger.kernel.org, Albert Ou , netdev@vger.kernel.org, Palmer Dabbelt , Linux Kernel Mailing List , nicolas.ferre@microchip.com, Sachin Ghadi , Yash Shah , robh+dt@kernel.org, ynezz@true.cz, linux-riscv@lists.infradead.org, davem@davemloft.net, Jim Jacobsen Content-Transfer-Encoding: quoted-printable Message-Id: References: <1560745167-9866-1-git-send-email-yash.shah@sifive.com> To: Paul Walmsley X-Mailer: Apple Mail (2.3445.9.1) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > On Jun 17, 2019, at 6:34 AM, Paul Walmsley = wrote: >=20 > On Mon, 17 Jun 2019, Andreas Schwab wrote: >=20 >> On Jun 17 2019, Paul Walmsley wrote: >>=20 >>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>>=20 >>>> On Jun 17 2019, Paul Walmsley wrote: >>>>=20 >>>>> Looks to me that it shouldn't have an impact unless the DT string = is=20 >>>>> present, and even then, the impact might simply be that the MACB = driver=20 >>>>> may not work? >>>>=20 >>>> If the macb driver doesn't work you have an unusable system, of = course. >>>=20 >>> Why? >>=20 >> Because a system is useless without network. >=20 > =46rom an upstream Linux point of view, Yash's patches should be an=20 > improvement over the current mainline kernel situation, since there's=20= > currently no upstream support for the (SiFive-specific) TX clock = switch=20 > register. With the right DT data, and a bootloader that handles the = PHY=20 > reset, I think networking should work after his patches are upstream = --=20 > although I myself haven't tried this yet. >=20 Have we documented this tx clock switch register in something with a direct URL link (rather than a PDF)? I=E2=80=99d like to update freedom-u-sdk (or yocto) to create bootable = images with a working U-boot (upstream or not, I don=E2=80=99t care, as long as = it works), and what I have right now is the old legacy HiFive U-boot[1] and a 4.19 kernel with a bunch of extra patches. The legacy M-mode U-boot handles the phy reset already, and I=E2=80=99ve = been able to load upstream S-mode uboot as a payload via TFTP, and then=20 load and boot a 4.19 kernel.=20 It would be nice to get this all working with 5.x, however there are = still several missing pieces to really have it work well. [1] https://github.com/sifive/HiFive_U-Boot=