From: Luke Howard <lukeh@padl.com>
To: sashiko-reviews@lists.linux.dev
Cc: robh@kernel.org, netdev@vger.kernel.org,
Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Cedric Jehasse <cedric.jehasse@gmail.com>,
Kieran Tyrrell <kieran@sienda.com>,
Max Holtmann <mh@rme-audio.de>, Max Hunter <max@huntershome.org>,
Christoph Mellauner <christoph.mellauner@joyned.at>,
Simon Gapp <simon.gapp@gapp-audio.com>
Subject: Re: [PATCH net-next v4 1/5] net: dsa: mv88e6xxx: only time stamp PTPv2 frames
Date: Tue, 28 Jul 2026 15:50:55 +1000 [thread overview]
Message-ID: <FCEF80BF-B088-4348-9377-A2ECAAD6B4CC@padl.com> (raw)
In-Reply-To: <20260728035958.951161F00A3A@smtp.kernel.org>
> [Severity: High]
> This isn't a bug introduced by this patch, but does ptp_parse_header()
> guarantee that the returned header is in the linear region of the skb?
This is a pre-existing bug shared by every caller of ptp_parse_header().
> [Severity: High]
> This is another pre-existing issue, but does using the
> MV88E6XXX_HWTSTAMP_ENABLED bit flag provide adequate synchronization?
Worst case is a timestamp request being dropped mid-reconfiguration. I don’t think this is worth addressing.
Luke
next prev parent reply other threads:[~2026-07-28 5:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 3:59 [PATCH net-next v4 0/5] net: dsa: mv88e6xxx: various hwstamp fixes Luke Howard
2026-07-27 3:59 ` [PATCH net-next v4 1/5] net: dsa: mv88e6xxx: only time stamp PTPv2 frames Luke Howard
[not found] ` <20260728035958.951161F00A3A@smtp.kernel.org>
2026-07-28 5:50 ` Luke Howard [this message]
2026-07-27 3:59 ` [PATCH net-next v4 2/5] net: dsa: mv88e6xxx: use ARRIVAL1 counter for all peer delay messages Luke Howard
2026-07-27 3:59 ` [PATCH net-next v4 3/5] net: dsa: mv88e6xxx: decouple the PTP timecounter from the register lock Luke Howard
[not found] ` <20260728040001.D87D21F00A3E@smtp.kernel.org>
2026-07-28 5:52 ` Luke Howard
2026-07-27 3:59 ` [PATCH net-next v4 4/5] dt-bindings: net: dsa: add EDSA arrival-timestamp tag protocol Luke Howard
2026-08-10 7:03 ` Krzysztof Kozlowski
2026-07-27 3:59 ` [PATCH net-next v4 5/5] net: dsa: mv88e6xxx: embedded PTP timestamp support Luke Howard
[not found] ` <20260728035957.DC9821F000E9@smtp.kernel.org>
2026-07-28 5:55 ` Luke Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FCEF80BF-B088-4348-9377-A2ECAAD6B4CC@padl.com \
--to=lukeh@padl.com \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=christoph.mellauner@joyned.at \
--cc=kieran@sienda.com \
--cc=kuba@kernel.org \
--cc=max@huntershome.org \
--cc=mh@rme-audio.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=simon.gapp@gapp-audio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox