From: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
To: Simon Horman <horms@kernel.org>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Greenwalt, Paul" <paul.greenwalt@intel.com>
Subject: RE: [PATCH iwl-next v2] ice: update ice_link_mode_str_high() with 200G
Date: Wed, 25 Mar 2026 07:01:02 +0000 [thread overview]
Message-ID: <IA3PR11MB8986A390B490C2B585B436E5E549A@IA3PR11MB8986.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20260324181612.GE111839@horms.kernel.org>
> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Tuesday, March 24, 2026 7:16 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; netdev@vger.kernel.org; Greenwalt, Paul
> <paul.greenwalt@intel.com>
> Subject: Re: [PATCH iwl-next v2] ice: update ice_link_mode_str_high()
> with 200G
>
> On Mon, Mar 23, 2026 at 09:58:40AM +0100, Aleksandr Loktionov wrote:
> > From: Paul Greenwalt <paul.greenwalt@intel.com>
> >
> > Update ice_link_mode_str_high() with strings for 200G PHY types.
> > Without these entries the ice_dump_phy_type() debug helper prints
> > nothing for phy_type_high bits [5..15], covering all 200G and
> > 400GBASE-FR8 PHY types supported by E825C hardware.
> >
> > Also add the corresponding ICE_PHY_TYPE_HIGH_* bit definitions for
> > indices 13-15 (200G_AUI8_AOC_ACC, 200G_AUI8, 400GBASE_FR8) that were
> > missing from ice_adminq_cmd.h, and update
> ICE_PHY_TYPE_HIGH_MAX_INDEX
> > from 12 to 15. Without these definitions ice_get_phy_type_high()
> > would stop iterating at index 12, leaving the new PHY types
> invisible
> > to all code that bounds-checks against MAX_INDEX.
> >
> > Fixes: none (new hardware support)
>
> AFAIK this is not a valid Fixes tag.
> If it's not a fix, please simply omit the tag.
> If you want to say something about why then use free form text.
>
Good day, Simon
There is v3 version, please have a look
> > Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> > Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> > ---
> > v1 -> v2 update ICE_PHY_TYPE_HIGH_MAX_INDEX
>
> ...
prev parent reply other threads:[~2026-03-25 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 8:58 [PATCH iwl-next v2] ice: update ice_link_mode_str_high() with 200G Aleksandr Loktionov
2026-03-23 9:10 ` [Intel-wired-lan] " Paul Menzel
2026-03-24 18:13 ` Simon Horman
2026-03-24 18:16 ` Simon Horman
2026-03-25 7:01 ` Loktionov, Aleksandr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA3PR11MB8986A390B490C2B585B436E5E549A@IA3PR11MB8986.namprd11.prod.outlook.com \
--to=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox