From: James Morris <jmorris@namei.org>
To: Eric Paris <eparis@parisplace.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Venkat Yekkirala <vyekkirala@trustedcs.com>,
Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa
Date: Mon, 5 Mar 2007 19:37:43 -0500 (EST) [thread overview]
Message-ID: <Line.LNX.4.64.0703051937320.17389@d.namei> (raw)
In-Reply-To: <1172866536.31047.32.camel@localhost.localdomain>
On Fri, 2 Mar 2007, Eric Paris wrote:
> Inside pfkey_delete and xfrm_del_sa the audit hooks were not called if
> there was any permission/security failures in attempting to do the del
> operation (such as permission denied from security_xfrm_state_delete).
> This patch moves the audit hook to the exit path such that all failures
> (and successes) will actually get audited.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-03-06 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 20:15 [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa Eric Paris
2007-03-05 16:00 ` Venkat Yekkirala
2007-03-06 0:37 ` James Morris [this message]
2007-03-07 23:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Line.LNX.4.64.0703051937320.17389@d.namei \
--to=jmorris@namei.org \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=vyekkirala@trustedcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).