From: James Morris <jmorris@namei.org>
To: Paul Moore <paul.moore@hp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] NetLabel: parse the CIPSO ranged tag on incoming packets
Date: Mon, 12 Mar 2007 10:50:41 -0400 (EDT) [thread overview]
Message-ID: <Line.LNX.4.64.0703121050180.9351@d.namei> (raw)
In-Reply-To: <20070312134615.294091233@flek.zko.hp.com>
On Mon, 12 Mar 2007, Paul Moore wrote:
> Commit 484b366932be0b73a22c74a82748ca10a721643e added support for the CIPSO
> ranged categories tag. However, it appears that I made a mistake when rebasing
> then patch to the latest upstream sources for submission and dropped the part
> of the patch that actually parses the tag on incoming packets. This patch
> fixes this mistake by adding the required function call to the
> cipso_v4_skbuff_getattr() function.
>
> I've run this patch over the weekend and have not noticed any problems.
>
> Signed-off-by: Paul Moore <paul.moore@hp.com>
Acked-by: James Morris <jmorris@namei.org>
> ---
> net/ipv4/cipso_ipv4.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> Index: net-2.6_bugfix_2/net/ipv4/cipso_ipv4.c
> ===================================================================
> --- net-2.6_bugfix_2.orig/net/ipv4/cipso_ipv4.c
> +++ net-2.6_bugfix_2/net/ipv4/cipso_ipv4.c
> @@ -1933,6 +1933,11 @@ int cipso_v4_skbuff_getattr(const struct
> &cipso_ptr[6],
> secattr);
> break;
> + case CIPSO_V4_TAG_RANGE:
> + ret_val = cipso_v4_parsetag_rng(doi_def,
> + &cipso_ptr[6],
> + secattr);
> + break;
> }
>
> skbuff_getattr_return:
>
> --
> paul moore
> linux security @ hp
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-03-12 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 13:45 [PATCH] NetLabel: parse the CIPSO ranged tag on incoming packets Paul Moore
2007-03-12 14:50 ` James Morris [this message]
2007-03-12 21:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Line.LNX.4.64.0703121050180.9351@d.namei \
--to=jmorris@namei.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox