Netdev List
 help / color / mirror / Atom feed
From: Jesse Van Gavere <jesse.vangavere@scioteq.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"woojung.huh@microchip.com" <woojung.huh@microchip.com>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"andrew@lunn.ch" <andrew@lunn.ch>
Subject: RE: DSA to switchdev (TI CPSW) ethernet ports
Date: Thu, 28 Nov 2024 15:42:18 +0000	[thread overview]
Message-ID: <PASP264MB52979414E483480C8FD26218FC292@PASP264MB5297.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20241128141948.orylugaetrga2bdb@skbuf>

Hello Vladimir,

>Caution! This message was sent from outside your organization.
>
>On Thu, Nov 28, 2024 at 02:01:23PM +0000, Jesse Van Gavere wrote:
>> Hello,
>> 
>> I have a question in regards to connecting switchdev ports (TI AM62 CPSW in my case) to a switch configured in the DSA framework.
>> My setup is two KSZ9896Cs connected, one to each port of the AM62x.
>> Using something like cpsw_port1/2 as the ethernet for the conduit port fails I presume in of_find_net_device_by_node(ethernet) as both eth seem to be under cpsw3g which is the actual ethernet.
>> 
>> So when changing the ethernet for the conduit port to cpsw3g I can actually get switch working, and I see it registers under eth0 of the ethernet, however when the second switch tries to come up it fails because it tries to register a dsa folder under eth0 again.
>> 
>> I'm kind of at a loss what the correct solution here would be, or if this is currently even supported to connect e.g. a cpsw port to a conduit port, if that would not be the case, what is the suggested work I'd best be doing to actually get this working?
>> 
>> Kind regards,
>> Jesse Van Gavere
>
>Having ethernet = <&cpsw_port1> or ethernet = <&cpsw_port2> is what should have worked. What is the actual failure?
>
>What do you mean "cpsw3g (...) is the actual ethernet"? How many netdevs does cpsw3g register? 2 (for the ports) or 3?
>
>Your setup should not be a problem in general, the switchdev model is compatible with usage as a DSA conduit. Could you print with %pOF what is the ndev->dev.of_node of the 2 cpsw ports?

Thank you very much for this information.
It immediately pointed me in the right direction and I could see this was Addressed by Jacub Kicinski in commit 29c71bf2a05a11f0d139590d37d92547477d5eb2
The netdev of_node simply wasn't being populated yet in the branch I'm working on, everything is working as expected now!

Thanks a lot!

Best regards,
Jesse

  reply	other threads:[~2024-11-28 15:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 14:01 DSA to switchdev (TI CPSW) ethernet ports Jesse Van Gavere
2024-11-28 14:19 ` Vladimir Oltean
2024-11-28 15:42   ` Jesse Van Gavere [this message]
2024-11-28 15:46     ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PASP264MB52979414E483480C8FD26218FC292@PASP264MB5297.FRAP264.PROD.OUTLOOK.COM \
    --to=jesse.vangavere@scioteq.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox