From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bodo Eggert <7eggert@gmx.de> Subject: Re: bonding: cannot remove certain named devices Date: Wed, 16 Aug 2006 17:11:19 +0200 (CEST) Message-ID: References: <6KfTz-OX-11@gated-at.bofh.it> <6KfTA-OX-15@gated-at.bofh.it> <20060815.171002.104028951.davem@davemloft.net> <44E2BC9C.1000101@debian.org> <20060816133811.GA26471@nostromo.devel.redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Giacomo A. Catenazzi" , David Miller , 7eggert@gmx.de, 7eggert@elstempel.de, shemminger@osdl.org, mitch.a.williams@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from moutng.kundenserver.de ([212.227.126.188]:5840 "EHLO moutng.kundenserver.de") by vger.kernel.org with ESMTP id S1751196AbWHPPRR (ORCPT ); Wed, 16 Aug 2006 11:17:17 -0400 To: Bill Nottingham In-Reply-To: <20060816133811.GA26471@nostromo.devel.redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 16 Aug 2006, Bill Nottingham wrote: > Giacomo A. Catenazzi (cate@debian.org) said: > > > Are you willing to work to add the special case code necessary to > > > handle whitespace characters in the device name over all of the kernel > > > code and also all of the userland tools too? > > > > But if you don't handle spaces in userspace, you handle *, ?, [, ], $, > > ", ', \ in userspace? Should kernel disable also these (insane device > > chars) chars? > > Don't forget unicode characters! And long names or control characters. > Seriously, while it might be insane to use some of these, I'm wondering > if trying to filter names is more work than fixing the tools. I think it's sane to avoid control characters and unicode/iso*, since they can interfere with log output or analysis. I only thought about the kernel itself and the corresponding userspace tools, which should handle any character sequence just fine or could be easily fixed. -- Top 100 things you don't want the sysadmin to say: 14. Any more trouble from you and your account gets moved to the 750