From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julian Anastasov <ja@ssi.bg>
Subject: Re: [rfc 13/13] [RFC 13/13] IPVS: sip persistence engine
Date: Sat, 18 Sep 2010 18:09:28 +0300 (EEST)
Message-ID: <Pine.LNX.4.58.1009181731240.8887@u.domain.uli>
References: <20100805114755.118303531@vergenet.net> <20100805115242.056724322@vergenet.net>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org,
	Wensong Zhang <wensong@linux-vs.org>,
	Patrick McHardy <kaber@trash.net>
To: Simon Horman <horms@verge.net.au>
Return-path: <netdev-owner@vger.kernel.org>
Received: from ja.ssi.bg ([178.16.129.10]:59232 "EHLO u.domain.uli"
	rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP
	id S1752546Ab0IRPDl (ORCPT <rfc822;netdev@vger.kernel.org>);
	Sat, 18 Sep 2010 11:03:41 -0400
In-Reply-To: <20100805115242.056724322@vergenet.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


	Hello,

On Thu, 5 Aug 2010, Simon Horman wrote:

> Add the SIP callid as a key for persistence.

...

> +static bool ip_vs_sip_ct_match(const struct ip_vs_conn_param *p,
> +				  struct ip_vs_conn *ct)
> +
> +{
> +	bool ret = 0;
> +
> +	if (ct->af == p->af &&
> +	    ip_vs_addr_equal(p->af, p->caddr, &ct->caddr) &&
> +	    /* protocol should only be IPPROTO_IP if
> +	     * d_addr is a fwmark */
> +	    ip_vs_addr_equal(p->protocol == IPPROTO_IP ? AF_UNSPEC : p->af,
> +			     p->vaddr, &ct->vaddr) &&
> +	    ct->vport == p->vport &&
> +	    ct->flags & IP_VS_CONN_F_TEMPLATE &&
> +	    ct->protocol == p->protocol &&
> +	    ct->pe_data && ct->pe_data_len == p->pe_data_len &&
> +	    !strnicmp(ct->pe_data, p->pe_data, p->pe_data_len))

	According to RFC 3261 8.1.1.4 Call-ID,
"Call-IDs are case-sensitive and are simply compared byte-by-byte",
so may be memcmp should be used.

	Also, may be ip_vs_sip_fill_param uses GFP_KERNEL in wrong 
context.

Regards

--
Julian Anastasov <ja@ssi.bg>