From: Arthur Kepner <akepner@sgi.com>
To: Anton Blanchard <anton@samba.org>
Cc: Leonid Grossman <leonid.grossman@neterion.com>,
muhammad.shafiq@neterion.com, ramkrishna.vepa@neterion.com,
netdev@oss.sgi.com
Subject: Re: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit()
Date: Mon, 2 May 2005 19:11:53 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.61.0505021844480.16692@linux.site> (raw)
In-Reply-To: <20050503014034.GC12682@krispykreme>
On Tue, 3 May 2005, Anton Blanchard wrote:
>
> I didnt know mmiowb is supposed to be a replacement for PCI write
> posting. Most architectures define mmiowb as nothing and so will be
> broken with your change.
>
I thought that an arch was supposed to define mmiowb() if it needs
it. In this case, the readq() is only being used for the side-effect
of ordering the previous writes (the neterion folks can correct me
if I'm wrong).
--
Arthur
next prev parent reply other threads:[~2005-05-03 2:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200504051836.j35IanDD005402@guinness.s2io.com>
2005-05-03 1:09 ` [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit() Arthur Kepner
2005-05-03 1:40 ` Anton Blanchard
2005-05-03 2:11 ` Arthur Kepner [this message]
2005-05-03 2:58 ` Ramkrishna Vepa
2005-05-03 3:06 ` Anton Blanchard
2005-05-03 14:52 ` Arthur Kepner
2005-05-03 16:23 ` Ramkrishna Vepa
2005-05-03 3:05 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0505021844480.16692@linux.site \
--to=akepner@sgi.com \
--cc=anton@samba.org \
--cc=leonid.grossman@neterion.com \
--cc=muhammad.shafiq@neterion.com \
--cc=netdev@oss.sgi.com \
--cc=ramkrishna.vepa@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).