Netdev List
 help / color / mirror / Atom feed
From: Radheka Godse <radheka.godse@intel.com>
To: fubar@us.ibm.com, bonding-devel@lists.sourceforge.net
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6.13-rc1 7/17] bonding: make sysfs consistent with ifenslave behavior
Date: Fri, 1 Jul 2005 13:47:04 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.61.0507011345580.17459@localhost.localdomain> (raw)

For consistency with ifenslave, instead of exiting with an error, updated 
bonding sysfs to close and attempt to enslave an up adapter.

Signed-off-by: Radheka Godse <radheka.godse@intel.com>
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>

diff -urN -X dontdiff linux-2.6.12post/drivers/net/bonding/bond_main.c linux-2.6.12post-sysfs/drivers/net/bonding/bond_main.c
--- linux-2.6.12post/drivers/net/bonding/bond_main.c	2005-06-28 18:18:03.000000000 -0700
+++ linux-2.6.12post-sysfs/drivers/net/bonding/bond_main.c	2005-06-30 13:53:55.000000000 -0700
@@ -1665,10 +1665,19 @@
  		 */
  		if ((slave_dev->flags & IFF_UP)) {
  			printk(KERN_ERR DRV_NAME
-			       ": Error: %s is up\n",
-			       slave_dev->name);
+			       ": %s: Warning: %s is up. Closing it "
+			       "before adding to the bond.\n",
+			       bond_dev->name, slave_dev->name);
  			res = -EPERM;
-			goto err_undo_flags;
+			res = dev_close(slave_dev);
+			if (res)
+			{
+				printk(KERN_ERR DRV_NAME
+				    ": %s: Error: Failed to close %s.\n",
+				    bond_dev->name, slave_dev->name);
+				res = -EPERM;
+				goto err_undo_flags;
+			}
  		}

  		if (slave_dev->set_mac_address == NULL) {

                 reply	other threads:[~2005-07-01 20:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0507011345580.17459@localhost.localdomain \
    --to=radheka.godse@intel.com \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox