From: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH] Implement NETDEV_FEAT_CHANGE
Date: Tue, 24 May 2005 00:32:19 +0300 (EEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0505232350060.17855@webhosting.rdsbv.ro> (raw)
In-Reply-To: <20050523093329.40617690@dxpl.pdx.osdl.net>
On Mon, 23 May 2005, Stephen Hemminger wrote:
>
>> --- notify1/net/core/ethtool.c 2005-03-02 09:38:37.000000000 +0200
>> +++ linux/net/core/ethtool.c 2005-05-23 11:30:47.000000000 +0300
> ...
>> @@ -712,7 +715,6 @@ int dev_ethtool(struct ifreq *ifr)
>> break;
>> case ETHTOOL_GDRVINFO:
>> rc = ethtool_get_drvinfo(dev, useraddr);
>> -
>> break;
>
> White space creep
Do you want to not touch that space?
>> case ETHTOOL_GREGS:
>> rc = ethtool_get_regs(dev, useraddr);
>> @@ -801,6 +803,10 @@ int dev_ethtool(struct ifreq *ifr)
>>
>> if(dev->ethtool_ops->complete)
>> dev->ethtool_ops->complete(dev);
>> +
>> + if (old_features != dev->features)
>> + netdev_features_change(dev);
>> +
>> return rc;
>>
>> ioctl:
>
> Did you check for any drivers that don't use ethtool_ops?
I checked now and I didn't find any possibility to change features.
So I think we are ok.
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/
prev parent reply other threads:[~2005-05-23 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 9:43 [PATCH] Implement NETDEV_FEAT_CHANGE Catalin(ux aka Dino) BOIE
2005-05-23 16:33 ` Stephen Hemminger
2005-05-23 21:32 ` Catalin(ux aka Dino) BOIE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0505232350060.17855@webhosting.rdsbv.ro \
--to=util@deuroconsult.ro \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox