Re: SFC driver implements its own I2C support

[Michael Brown <mbrown@fensystems.co.uk>]

On Thu, 15 May 2008, Jean Delvare wrote:
> > I think there may also have been issues with the fact that the i2c 
> > system allows for failures on the shutdown path (e.g. 
> > i2c_detach_client() can return a failure), which becomes awkward to 
> > handle when you are in the middle of a shutdown path that is not 
> > allowed to fail (e.g. a pci_driver->remove method).
> 
> This part of the code has been reworked completely. That being said, I 
> see that the i2c_driver remove method returns an int not void, so it can 
> still fail. There doesn't seem to be a common behavior in this respect 
> amongst subsystems, some allow the remove method to fail and others 
> don't. If you think that the i2c subsystem should not let remove methods 
> fail, we can discuss this. But most likely, the error code is purely 
> informative so it doesn't really matter if we return it or void.

It does matter if the i2c remove failure indicates that data structures 
are still left linked in to various lists etc.

Michael