From: James Morris <jmorris@namei.org>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: netdev@oss.sgi.com
Subject: [PATCH/RFC] Remove spurious sk_filter() call from IPv6
Date: Tue, 25 Oct 2005 12:48:14 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.63.0510251242070.17321@excalibur.intercode> (raw)
It seems that the IPv6 input path has an extra call to sk_filter().
First, the correct call to sk_filter() in tcp_v6_rcv(), matching the IPv4
code.
Then, again in tcp_v6_do_rcv(), which often results in a somewhat already
processed skb being passed to sk_filter().
As far as I can tell, we should remove this second call, as it is both
incorrect and uncecessary.
Please review and apply if ok.
Signed-off-by: James Morris <jmorris@namei.org>
---
net/ipv6/tcp_ipv6.c | 3 ---
1 files changed, 3 deletions(-)
diff -purN -X dontdiff linux-2.6.14-rc5.o/net/ipv6/tcp_ipv6.c linux-2.6.14-rc5.ipv6/net/ipv6/tcp_ipv6.c
--- linux-2.6.14-rc5.o/net/ipv6/tcp_ipv6.c 2005-10-21 00:43:33.000000000 -0400
+++ linux-2.6.14-rc5.ipv6/net/ipv6/tcp_ipv6.c 2005-10-25 12:44:23.000000000 -0400
@@ -1451,9 +1451,6 @@ static int tcp_v6_do_rcv(struct sock *sk
if (skb->protocol == htons(ETH_P_IP))
return tcp_v4_do_rcv(sk, skb);
- if (sk_filter(sk, skb, 0))
- goto discard;
-
/*
* socket locking is here for SMP purposes as backlog rcv
* is currently called with bh processing disabled.
reply other threads:[~2005-10-25 16:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0510251242070.17321@excalibur.intercode \
--to=jmorris@namei.org \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox