From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH 7/32] [TIPC] Multicast link failure now resets all links to "nacking" node. Date: Thu, 22 Jun 2006 14:51:29 -0400 (EDT) Message-ID: References: <1150984785859-git-send-email-per.liden@ericsson.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: David Miller , netdev@vger.kernel.org, Allan Stephens Return-path: Received: from mail5.sea5.speakeasy.net ([69.17.117.7]:26853 "EHLO mail5.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S1161182AbWFVSvc (ORCPT ); Thu, 22 Jun 2006 14:51:32 -0400 To: Per Liden In-Reply-To: <1150984785859-git-send-email-per.liden@ericsson.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 22 Jun 2006, Per Liden wrote: > +static void link_reset_all(unsigned long addr) > +{ > + struct node *n_ptr; > + char addr_string[16]; > + u32 i; > + > + read_lock_bh(&tipc_net_lock); > + n_ptr = tipc_node_find((u32)addr); > + if (!n_ptr) { > + read_unlock_bh(&tipc_net_lock); > + return; /* node no longer exists */ > + } > + > + tipc_node_lock(n_ptr); You already have bh's disabled here, and tipc_node_lock() also disables them. Not sure if it's really worth worrying about but if so, you could perhaps implement tipc_node_lock_bh() and tipc_node_lock(). - James -- James Morris