Netdev List
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@voltaire.com>
To: netdev@vger.kernel.org
Subject: active-backup/bonding with drivers not supporting set_mac_address()
Date: Mon, 10 Jul 2006 16:43:36 +0300 (IDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0607101618390.26558@zuben> (raw)

Looking on the linux bonding driver, it seems to unconditionally (*)
assume that the enslaved device supports the set_mac_address call.

>From reading the doc (Documentation/networking/bonding.txt) i understand that
it is **not** a must prerequisite for the active-backup mode, this is since
there is at most one active slave at each point of time and as the doc states:

	when a failover occurs in active-backup mode, bonding will issue
	one or more gratuitous ARPs on the newly active slave.

I'd like to get feedback from people here if you think it makes sense
to change the bonding driver to actually allow for active-backup/bonding
with network device drivers which does not support set_mac_address.

thanks,

Or Gerlitz.

(*) in the sense that it checks for each enslaved device and reports
an error if dev->set_mac_address is not supported and later use
dev_set_mac_address elsewhere in the code.


             reply	other threads:[~2006-07-10 13:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 13:43 Or Gerlitz [this message]
2006-07-10 18:23 ` active-backup/bonding with drivers not supporting set_mac_address() David Miller
2006-07-10 18:31   ` Jay Vosburgh
2006-07-10 18:46     ` David Miller
2006-07-10 18:29 ` Jay Vosburgh
2006-07-10 18:45   ` David Miller
2006-07-11  5:29     ` Jay Vosburgh
2006-07-11 13:33   ` Or Gerlitz
2006-07-11 14:01   ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0607101618390.26558@zuben \
    --to=ogerlitz@voltaire.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox