public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@voltaire.com>
To: netdev@vger.kernel.org
Cc: Roland Dreier <rdreier@cisco.com>
Subject: [RFC] [PATCH 3/3] enable IP multicast when bonding IPoIB devices
Date: Tue, 26 Sep 2006 13:18:09 +0300 (IDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0609261317460.24189@zuben> (raw)
In-Reply-To: <Pine.LNX.4.64.0609261309540.24189@zuben>

Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com>

Index: net-2.6.19/drivers/net/bonding/bond_main.c
===================================================================
--- net-2.6.19.orig/drivers/net/bonding/bond_main.c	2006-09-25 11:46:35.000000000 +0300
+++ net-2.6.19/drivers/net/bonding/bond_main.c	2006-09-26 10:54:44.000000000 +0300
@@ -128,6 +128,12 @@ MODULE_PARM_DESC(arp_interval, "arp inte
 module_param_array(arp_ip_target, charp, NULL, 0);
 MODULE_PARM_DESC(arp_ip_target, "arp targets in n.n.n.n form");

+static int bonding_dev_type    = ARPHRD_ETHER;
+static int bonding_dev_addrlen = ETH_ALEN;
+
+module_param(bonding_dev_type,    int, 0644);
+module_param(bonding_dev_addrlen, int, 0644);
+
 /*----------------------------- Global variables ----------------------------*/

 static const char * const version =
@@ -4606,7 +4612,14 @@ int bond_create(char *name, struct bond_
 		res = -ENOMEM;
 		goto out_rtnl;
 	}
-
+
+	/* XXX set the bond dev type and addr len such that the net core code
+	* (eg arp_mc_map() in net/ipv4/arp.c) would correctly process multicast
+	* groups set ***before*** the first enslaveness
+	*/
+	bond_dev->type     = bonding_dev_type;
+	bond_dev->addr_len = bonding_dev_addrlen;
+
 	/* bond_init() must be called after dev_alloc_name() (for the
 	 * /proc files), but before register_netdevice(), because we
 	 * need to set function pointers.


  parent reply	other threads:[~2006-09-26 10:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26 10:16 [RFC][PATCH 0/3] bonding support for operation over IPoIB Or Gerlitz
2006-09-26 10:17 ` [RFC][PATCH 1/3] enable bonding to enslave non ARPHRD_ETHER netdevices Or Gerlitz
2006-09-26 19:23   ` Jay Vosburgh
2006-09-27 19:59     ` Or Gerlitz
2006-09-28 17:02       ` Jay Vosburgh
2006-10-03 12:56         ` Or Gerlitz
2006-09-26 10:17 ` [RFC][PATCH 2/3] enable bonding to enslave netdevices not supporting set_mac_address() Or Gerlitz
2006-09-26 10:18 ` Or Gerlitz [this message]
2006-09-26 17:05   ` [RFC] [PATCH 3/3] enable IP multicast when bonding IPoIB devices Stephen Hemminger
2006-09-27 20:16     ` Or Gerlitz
2006-09-26 23:40   ` Jay Vosburgh
2006-09-27 20:12     ` Or Gerlitz
2006-09-28 17:43       ` Jay Vosburgh
2006-10-03 13:06         ` Or Gerlitz
2006-10-03 23:10           ` Jay Vosburgh
2006-10-04 15:25             ` Or Gerlitz
2006-10-04 17:34               ` Jay Vosburgh
2006-10-05 14:56                 ` Or Gerlitz
2006-10-05 18:13                   ` Jay Vosburgh
2006-10-09 13:15                     ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0609261317460.24189@zuben \
    --to=ogerlitz@voltaire.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox