From: Or Gerlitz <ogerlitz@voltaire.com>
To: netdev@vger.kernel.org
Cc: openib-general@openib.org, Roland Dreier <rdreier@cisco.com>,
Jay Vosburgh <fubar@us.ibm.com>
Subject: [RFC] [PATCH V2 3/3] enable IP multicast for bonding IPoIB devices - allow not UP enslavement
Date: Thu, 30 Nov 2006 12:58:35 +0200 (IST) [thread overview]
Message-ID: <Pine.LNX.4.64.0611301257520.26156@zuben> (raw)
In-Reply-To: <Pine.LNX.4.64.0611301256130.26156@zuben>
Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com>
Index: net-2.6.20/drivers/net/bonding/bond_sysfs.c
===================================================================
--- net-2.6.20.orig/drivers/net/bonding/bond_sysfs.c 2006-11-30 10:45:53.000000000 +0200
+++ net-2.6.20/drivers/net/bonding/bond_sysfs.c 2006-11-30 10:48:13.000000000 +0200
@@ -265,11 +265,9 @@ static ssize_t bonding_store_slaves(stru
/* Quick sanity check -- is the bond interface up? */
if (!(bond->dev->flags & IFF_UP)) {
- printk(KERN_ERR DRV_NAME
- ": %s: Unable to update slaves because interface is down.\n",
+ printk(KERN_WARNING DRV_NAME
+ ": %s: doing slave updates when interface is down.\n",
bond->dev->name);
- ret = -EPERM;
- goto out;
}
/* Note: We can't hold bond->lock here, as bond_create grabs it. */
Index: net-2.6.20/drivers/net/bonding/bond_main.c
===================================================================
--- net-2.6.20.orig/drivers/net/bonding/bond_main.c 2006-11-30 10:46:57.000000000 +0200
+++ net-2.6.20/drivers/net/bonding/bond_main.c 2006-11-30 10:48:13.000000000 +0200
@@ -1298,8 +1298,8 @@ int bond_enslave(struct net_device *bond
/* bond must be initialized by bond_open() before enslaving */
if (!(bond_dev->flags & IFF_UP)) {
- dprintk("Error, master_dev is not up\n");
- return -EPERM;
+ printk(KERN_WARNING DRV_NAME
+ " %s: master_dev is not up in bond_enslave\n", bond_dev->name);
}
/* already enslaved */
next prev parent reply other threads:[~2006-11-30 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 10:56 [RFC] [PATCH V2 0/3] bonding support for operation over IPoIB Or Gerlitz
2006-11-30 10:57 ` [RFC][PATCH V2 1/3] enable bonding to enslave non ARPHRD_ETHER netdevices Or Gerlitz
2006-11-30 11:09 ` Or Gerlitz
2006-11-30 10:57 ` [RFC][PATCH V2 2/3] enable bonding to enslave netdevices not supporting set_mac_address() Or Gerlitz
2006-11-30 10:58 ` Or Gerlitz [this message]
2006-11-30 11:00 ` [RFC] [PATCH V2 0/3] bonding support for operation over IPoIB - example config script Or Gerlitz
2007-01-11 15:03 ` [RFC] [PATCH V2 0/3] bonding support for operation over IPoIB Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611301257520.26156@zuben \
--to=ogerlitz@voltaire.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox