From: James Morris <jmorris@namei.org>
To: Shinta Sugimoto <shinta@sfc.wide.ad.jp>
Cc: netdev@vger.kernel.org,
Francis Dupont <Francis.Dupont@point6.net>,
Masahide Nakamura <nakam@linux-ipv6.org>,
usagi-core@linux-ipv6.org
Subject: Re: [RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint update (MIGRATE)
Date: Fri, 2 Feb 2007 07:51:14 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702020747340.16188@d.namei> (raw)
In-Reply-To: <20070202203550.E2F3.SHINTA@sfc.wide.ad.jp>
On Fri, 2 Feb 2007, Shinta Sugimoto wrote:
> >
> > > +EXPORT_SYMBOL(xfrm_state_clone);
> >
> > Why not EXPORT_SYMBOL_GPL ?
> > (for all of your exports).
>
> Actually I don't have specific preference on either EXPORT_SYMBOL or
> EXPORT_SYMBOL_GPL. It seemed to me that other functions defined in
> files under net/xfrm/ are using EXPORT_SYMBOL, so I followed that.
Hmm, you're right, most of them are not _GPL.
> Do you think EXPORT_SYMBOL_GPL is more appropriate in this case?
Well, I would have thought that users of xfrm were generally derivative of
the kernel, but it doesn't make much sense to have only a couple of
symbols exported as GPL, so probably keep it the way you already have it.
- James
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2007-02-02 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 4:10 [RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint update (MIGRATE) Shinta Sugimoto
2007-02-01 14:45 ` James Morris
2007-02-02 11:47 ` Shinta Sugimoto
2007-02-02 12:51 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702020747340.16188@d.namei \
--to=jmorris@namei.org \
--cc=Francis.Dupont@point6.net \
--cc=nakam@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
--cc=shinta@sfc.wide.ad.jp \
--cc=usagi-core@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox