From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert P. J. Day" Subject: Re: [PATCH] IP_VS should depend on EXPERIMENTAL ? Date: Fri, 20 Jul 2007 08:21:52 -0400 (EDT) Message-ID: References: <46A0A01A.7030403@googlemail.com> <46A0A7C2.3090006@googlemail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Linux Kernel Mailing List , netdev@vger.kernel.org To: Gabriel C Return-path: Received: from nic.NetDirect.CA ([216.16.235.2]:38261 "EHLO rubicon.netdirect.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759729AbXGTMXq (ORCPT ); Fri, 20 Jul 2007 08:23:46 -0400 In-Reply-To: <46A0A7C2.3090006@googlemail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 20 Jul 2007, Gabriel C wrote: > Robert P. J. Day wrote: > > On Fri, 20 Jul 2007, Gabriel C wrote: > > > >> Hi, > >> > >> IP_VS has : > >> > >> .. > >> > >> tristate "IP virtual server support (EXPERIMENTAL)" > >> > >> .. > >> > >> but it does not depend on EXPERIMENTAL. > >> > >> > >> Signed-off-by: Gabriel Craciunescu > >> > >> --- > >> > >> net/ipv4/ipvs/Kconfig | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/net/ipv4/ipvs/Kconfig b/net/ipv4/ipvs/Kconfig > >> index 09d0c3f..3c594ec 100644 > >> --- a/net/ipv4/ipvs/Kconfig > >> +++ b/net/ipv4/ipvs/Kconfig > >> @@ -3,7 +3,7 @@ > >> # > >> menuconfig IP_VS > >> tristate "IP virtual server support (EXPERIMENTAL)" > >> - depends on NETFILTER > >> + depends on NETFILTER && EXPERIMENTAL > >> ---help--- > >> IP Virtual Server support will let you build a high-performance > >> virtual server based on cluster of two or more real servers. This > > > > there's maturity-level inconsistency like that in a few places, like > > when stuff is tagged as EXPERIMENTAL, but labelled as OBSOLETE: > > > [ a lot examples ] > > I know that and there are a lot more things depending on > 'EXPERIMENTAL' and not having EXPERIMENTAL visible all over the tree > but that patch I've made for the _net_ part got NACK'ed while your > maturity idea and I rm -rf'ed all the other. > > This one has a missing depends on EXPERIMENTAL while saying it is. > > So *could* we please stop this maturity stuff for now ? I don't see > it in .23 nor .24 if at all. this has *nothing* to do with the aforementioned maturity levels. i understand entirely the inconsistency above. what i'm suggesting is that it might very well be more appropriate to *drop the dependency* rather than munge the prompt to add the qualifier. i think it's safe to say that there's *piles* of stuff in the Kconfig files that is still saddled with an EXPERIMENTAL dependency that's been around for years and has stabilized nicely. i mean, seriously, is IP virtual server support still "experimental" in any way? rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================