From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of
 tc_classify()
Date: Fri, 31 Aug 2007 11:35:38 +0200 (CEST)
Message-ID: <Pine.LNX.4.64.0708311135190.8423@x2>
References: <20070830072817.GA9617@xanadu.blop.info>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: netdev@vger.kernel.org
To: Lucas Nussbaum <lucas.nussbaum@imag.fr>
Return-path: <netdev-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:53906 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754997AbXHaJgu (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 31 Aug 2007 05:36:50 -0400
In-Reply-To: <20070830072817.GA9617@xanadu.blop.info>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Thu, 30 Aug 2007, Lucas Nussbaum wrote:

> When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in
> prio_classify(). This causes "interesting" behaviour: with the setup
> below, packets are duplicated, sent twice to ifb0, and then loop in and
> out of ifb0.
>
> The patch uses the previously calculated return value in the switch,
> which is probably what Patrick had in mind in commit
> bdba91ec70fb5ccbdeb1c7068319adc6ea9e1a7d -- maybe Patrick can
> double-check this?


Thanks for catching this, this is indeed what I had in mind.