From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
To: David Miller <davem@davemloft.net>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations
Date: Thu, 20 Sep 2007 22:18:13 +0300 (EEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0709202214460.7764@kivilampi-30.cs.helsinki.fi> (raw)
In-Reply-To: <20070920.114106.124084391.davem@davemloft.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 673 bytes --]
On Thu, 20 Sep 2007, David Miller wrote:
> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Thu, 20 Sep 2007 15:17:52 +0300
>
> > There's no reason to clear the sacktag skb hint when small part
> > of the rexmit queue changes. Account changes (if any) instead when
> > fragmenting/collapsing. RTO/FRTO do not touch SACKED_ACKED bits so
> > no need to discard SACK tag hint at all.
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>
> Applied, and I followed it up with this coding style fixlet.
Yeah, that's for fixing it... ...Just didn't notice it was left wrong
while doing things that required more thinking to get them right...
--
i.
next prev parent reply other threads:[~2007-09-20 19:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 12:17 [PATCH net-2.6.24 0/9]: TCP improvements & cleanups Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 2/9] [TCP]: Make fackets_out accurate Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_ Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 7/9] [TCP] FRTO: Update sysctl documentation Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations Ilpo Järvinen
2007-09-20 18:41 ` David Miller
2007-09-20 19:18 ` Ilpo Järvinen [this message]
2007-09-20 18:36 ` [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default David Miller
2007-09-20 18:35 ` [PATCH 7/9] [TCP] FRTO: Update sysctl documentation David Miller
2007-09-20 18:35 ` [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users David Miller
2007-09-20 18:33 ` [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue David Miller
2007-09-20 18:33 ` [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue David Miller
2007-09-20 18:31 ` [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_ David Miller
2007-09-20 18:30 ` [PATCH 2/9] [TCP]: Make fackets_out accurate David Miller
2007-09-20 18:29 ` [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0709202214460.7764@kivilampi-30.cs.helsinki.fi \
--to=ilpo.jarvinen@helsinki.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).