From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
To: TAKANO Ryousei <takano@axe-inc.co.jp>
Cc: Netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems
Date: Thu, 11 Oct 2007 13:12:49 +0300 (EEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0710111300280.23026@kivilampi-30.cs.helsinki.fi> (raw)
In-Reply-To: <20071011.105526.17823985.takano@axe-inc.co.jp>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1009 bytes --]
On Thu, 11 Oct 2007, TAKANO Ryousei wrote:
> From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
> Subject: [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems
> Date: Tue, 9 Oct 2007 15:20:01 +0300
>
> Thanks Ilpo! I am trying to evaluate this patch.
There's a minor problem in this 2nd patch, it's just preventing the
cnt == tp->retrans_out short-circuit from working, not a correctness
problem though it could affect the performance. I'll post larger patch
series among which is a fixed version (hopefully today).
> But, I got
> a kernel panic at net_rx_action() in our experimental setting.
> I am using the net-2.6.24 kernel _without_ this patch.
> (I will post a bug report separately).
...Please do. :-)
> Anyway, I will report the result as soon as possible.
Thanks. ...It's very interesting to see because it's not that clear
cut how the extra processing that is necessary affects high-speed
performance, it could add yet another source of RTOs due
processing latency.
--
i.
next prev parent reply other threads:[~2007-10-11 10:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 12:19 [RFC PATCH net-2.6.24 0/3]: Attempt to fix lost_retrans brokeness Ilpo Järvinen
2007-10-09 12:20 ` [PATCH] [TCP]: Separate lost_retrans loop into own function Ilpo Järvinen
2007-10-09 12:20 ` [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems Ilpo Järvinen
2007-10-09 12:20 ` [RFC PATCH] [TCP]: Limit processing lost_retrans loop to work-to-do cases Ilpo Järvinen
2007-10-10 9:44 ` David Miller
2007-10-10 9:44 ` David Miller
2007-10-11 1:55 ` [RFC PATCH] [TCP]: Fix lost_retrans loop vs fastpath problems TAKANO Ryousei
2007-10-11 10:12 ` Ilpo Järvinen [this message]
2007-10-11 13:51 ` Regression in net-2.6.24? TAKANO Ryousei
2007-10-11 23:48 ` David Miller
2007-10-11 23:55 ` Stephen Hemminger
2007-10-12 0:17 ` David Miller
2007-10-12 0:31 ` Stephen Hemminger
2007-10-12 0:40 ` David Miller
2007-10-12 0:50 ` Stephen Hemminger
2007-10-12 1:00 ` David Miller
2007-10-12 1:03 ` David Miller
2007-10-12 1:14 ` David Miller
2007-10-12 1:22 ` Stephen Hemminger
2007-10-12 1:25 ` David Miller
2007-10-12 3:17 ` Michael Chan
2007-10-12 2:40 ` David Miller
2007-10-12 8:54 ` Michael Chan
2007-10-12 8:39 ` David Miller
2007-10-12 10:22 ` TAKANO Ryousei
2007-10-12 10:56 ` David Miller
2007-10-10 9:45 ` [PATCH] [TCP]: Separate lost_retrans loop into own function David Miller
2007-10-09 13:03 ` [RFC PATCH net-2.6.24 0/3]: Attempt to fix lost_retrans brokeness Ilpo Järvinen
2007-10-10 9:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0710111300280.23026@kivilampi-30.cs.helsinki.fi \
--to=ilpo.jarvinen@helsinki.fi \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=takano@axe-inc.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).