From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
To: Rainer Jochem <rainer.jochem@mpi-sb.mpg.de>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
kaber@trash.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pcernko@mpi-sws.mpg.de
Subject: Re: [PATCH] ipconfig.c : implement DHCP Class-identifier
Date: Thu, 8 Nov 2007 22:27:16 +0200 (EET) [thread overview]
Message-ID: <Pine.LNX.4.64.0711082225330.26833@kivilampi-30.cs.helsinki.fi> (raw)
In-Reply-To: <20071108143205.GA22490@mpi-sb.mpg.de>
On Thu, 8 Nov 2007, Rainer Jochem wrote:
> @@ -620,6 +622,17 @@ ic_dhcp_init_options(u8 *options)
> *e++ = sizeof(ic_req_params);
> memcpy(e, ic_req_params, sizeof(ic_req_params));
> e += sizeof(ic_req_params);
> +
> + // Send it only if the according kernel parameter was set
No C99 comments please. Though I'm not sure if this comment is that
necessary anyway...
> + if (*vendor_class_identifier) {
> + printk(KERN_INFO "Sending class identifier \"%s\"\n",
> + vendor_class_identifier);
> + *e++ = 60; /* Class-identifier */
> + *e++ = strlen(vendor_class_identifier);
> + memcpy(e, vendor_class_identifier,
> + strlen(vendor_class_identifier));
> + e += strlen(vendor_class_identifier);
> + }
> }
>
> *e++ = 255; /* End of the list */
--
i.
prev parent reply other threads:[~2007-11-08 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 14:32 [PATCH] ipconfig.c : implement DHCP Class-identifier Rainer Jochem
2007-11-08 15:45 ` Patrick McHardy
2007-11-14 8:44 ` Rainer Jochem
2007-11-14 8:56 ` Patrick McHardy
2007-11-14 9:45 ` Rainer Jochem
2007-11-14 9:48 ` Patrick McHardy
2007-11-14 10:18 ` David Miller
2007-11-14 22:11 ` Francois Romieu
2007-11-20 5:56 ` David Miller
2007-11-08 20:27 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711082225330.26833@kivilampi-30.cs.helsinki.fi \
--to=ilpo.jarvinen@helsinki.fi \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcernko@mpi-sws.mpg.de \
--cc=rainer.jochem@mpi-sb.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).