From: Guennadi Liakhovetski <lg@denx.de>
To: netdev@vger.kernel.org
Subject: Bug in cs89x0.c?
Date: Fri, 28 Mar 2008 16:09:06 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803281603110.4646@axis700.grange> (raw)
Hi
Do I understand it right, that this
705: i = readreg(dev, PP_LineCTL);
706: /* Preserve the setting of the HCB1 pin. */
707: if ((i & (HCB1 | HCB1_ENBL)) == (HCB1 | HCB1_ENBL))
708: lp->adapter_cnf |= A_CNF_DC_DC_POLARITY;
(line numbers may deviate slightly) is a bug? HCB1 and HCB1_ENBL bits are
from the PP_SelfCTL and not from the PP_LineCTL register...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
reply other threads:[~2008-03-28 15:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803281603110.4646@axis700.grange \
--to=lg@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox