From: Julia Lawall <julia@diku.dk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference
Date: Mon, 12 May 2008 18:53:01 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0805121852510.16384@ask.diku.dk> (raw)
In-Reply-To: <20080512161734.GA22190@electric-eye.fr.zoreil.com>
On Mon, 12 May 2008, Francois Romieu wrote:
> Julia Lawall <julia@diku.dk> :
> [...]
> > diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> > --- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200
> > +++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200
> > @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int
> > struct net_device *dev = (struct net_device *) dev_id;
> >
> > if (dev == NULL) {
> > - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
> > + printk(KERN_ERR "isr: null dev ptr\n");
> > return IRQ_RETVAL(1);
> > }
>
> The lifespan of 'dev' covers the request_irq..free_irq interval in this
> driver. The whole 'dev == NULL' block can be removed.
Will you do that?
julia
next prev parent reply other threads:[~2008-05-12 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:37 [PATCH 3/6] drivers/net: remove null pointer dereference Julia Lawall
2008-05-12 16:17 ` Francois Romieu
2008-05-12 16:53 ` Julia Lawall [this message]
2008-05-12 16:44 ` [PATCH] au1000_eth: remove useless check Francois Romieu
2008-05-22 10:22 ` Jeff Garzik
2008-05-12 17:06 ` [PATCH 3/6] drivers/net: remove null pointer dereference Jeff Garzik
2008-05-12 18:48 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805121852510.16384@ask.diku.dk \
--to=julia@diku.dk \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).