Re: [Bugme-new] [Bug 10767] New: Seg Fault Instead of Swapping

["Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1124 bytes --]

On Tue, 3 Jun 2008, David Miller wrote:

> From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> Date: Mon, 26 May 2008 14:24:33 +0300 (EEST)
> 
> Ilpo, do you want me to apply this to net-2.6?

Yes thanks, it is necessary to keep the state consistent (it also explains 
some .22/23 time left_out warn_ons too which were mysterious back then).
Also -stable (I guess it would be necessary to almost any older stable
too though some older ones might want to sync left_out on that same place 
too).

It was nice that this path was also triggered while running the TCP 
debug patch (I haven't gotten a one in here), otherwise we would never
have known though I started to suspect that such path existed once I
tried to analyze those left_out problems (before it got dropped 
altogether), but I just couldn't find the problem because it lies on 
such "error path" which was too easy to overlook.

I also finally have found the cause to the !sacked_out && fackets_out
trap :-). ...I'll post the fix to that later today to relevant parties.

> > [PATCH] [TCP]: Fix inconsistency source (CA_Open only when !tcp_left_out(tp))


-- 
 i.