From: Julia Lawall <julia@diku.dk>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/net/mlx4: Adjust constant
Date: Sun, 19 Jul 2009 21:08:40 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0907192108270.18234@ask.diku.dk> (raw)
In-Reply-To: <1248027891.31365.17.camel@Joe-Laptop.home>
Thanks for pointing this out. I will look into it.
julia
On Sun, 19 Jul 2009, Joe Perches wrote:
> On Sun, 2009-07-19 at 18:09 +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@diku.dk>
> >
> > The values in the advertising field are typically ADVERTISED_xxx, not
> > SUPPORTED_xxx. Both SUPPORTED_10000baseT_Full and
> > ADVERTISED_1000baseT_Full have the same value.
>
> other possibles:
>
> drivers/net/sungem.c:#define ADVERTISE_MASK (SUPPORTED_10baseT_Half | SUPPORTED_10baseT_Full | \
> SUPPORTED_100baseT_Half | SUPPORTED_100baseT_Full | \
> SUPPORTED_1000baseT_Half | SUPPORTED_1000baseT_Full | \
> SUPPORTED_Pause | SUPPORTED_Autoneg)
> drivers/net/s2io.c: info->advertising = (SUPPORTED_10000baseT_Full | SUPPORTED_FIBRE);
> drivers/net/spider_net.c: advertise |= SUPPORTED_1000baseT_Full;
> drivers/net/spider_net.c: advertise |= SUPPORTED_1000baseT_Half;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-07-19 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 16:09 [PATCH] drivers/net/mlx4: Adjust constant Julia Lawall
2009-07-19 18:24 ` Joe Perches
2009-07-19 19:08 ` Julia Lawall [this message]
2009-07-21 20:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0907192108270.18234@ask.diku.dk \
--to=julia@diku.dk \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox