Netdev List
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
	netdev@vger.kernel.org
Subject: question about drivers/atm/firestream.c
Date: Sat, 15 Aug 2009 19:08:06 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0908151906020.20096@ask.diku.dk> (raw)

In the file drivers/atm/firestream.c in the function fs_open, there is the 
following code:

       if (vci != ATM_VPI_UNSPEC && vpi != ATM_VCI_UNSPEC)
                set_bit(ATM_VF_ADDR, &atm_vcc->flags);

Should ATM_VPI_UNSPEC and ATM_VCI_UNSPEC be exchanged?  They have the same 
value, but the code looks a bit odd this way nonetheless.

thanks,
julia

             reply	other threads:[~2009-08-15 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-15 17:08 Julia Lawall [this message]
2009-08-17 14:25 ` question about drivers/atm/firestream.c Chas Williams (CONTRACTOR)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0908151906020.20096@ask.diku.dk \
    --to=julia@diku.dk \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox