From: Julia Lawall <julia@diku.dk>
To: walter harms <wharms@bfs.de>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>,
kernel-janitors@vger.kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error check
Date: Sat, 2 Oct 2010 16:21:23 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1010021621000.21879@ask.diku.dk> (raw)
In-Reply-To: <4CA73D26.7090109@bfs.de>
On Sat, 2 Oct 2010, walter harms wrote:
>
>
> Julia Lawall schrieb:
> > This code does not call deinit_card(card); in an error case, as done in
> > other error-handling code in the same function. But actually, the called
> > function init_sram can only return 0, so there is no need for the error
> > check at all.
> >
>
>
> did you set init_sram() to void ?
No, that indeed seems like a reasonable change. Patch shortly.
julia
next prev parent reply other threads:[~2010-10-02 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 13:59 [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error check Julia Lawall
2010-10-02 14:09 ` walter harms
2010-10-02 14:21 ` Julia Lawall [this message]
2010-10-02 14:37 ` Julia Lawall
2010-10-04 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1010021621000.21879@ask.diku.dk \
--to=julia@diku.dk \
--cc=chas@cmf.nrl.navy.mil \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).